Skip to content

Commit

Permalink
make engine_version mandatory
Browse files Browse the repository at this point in the history
  • Loading branch information
mandar242 committed Oct 3, 2023
1 parent f7be860 commit 221fa26
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions roles/create_rds_global_cluster/tasks/create.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
amazon.cloud.rds_global_cluster:
global_cluster_identifier: "{{ create_rds_global_cluster_global_cluster_name }}"

Check warning on line 9 in roles/create_rds_global_cluster/tasks/create.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

jinja[spacing]

Jinja2 spacing could be improved: {{ create_rds_global_cluster_engine | default('aurora-postgresql')}} -> {{ create_rds_global_cluster_engine | default('aurora-postgresql') }}
engine: "{{ create_rds_global_cluster_engine | default('aurora-postgresql')}}"
engine_version: "{{ create_rds_global_cluster_engine_version | default(omit) }}"
engine_version: "{{ create_rds_global_cluster_engine_version }}"
region: "{{ create_rds_global_cluster_primary_cluster_region }}"
state: present

Expand All @@ -17,7 +17,7 @@
db_cluster_identifier: "{{ create_rds_global_cluster_primary_cluster_name | default('{{ create_rds_global_cluster_global_cluster_name }}') }}" #aka cluster_name

Check warning on line 17 in roles/create_rds_global_cluster/tasks/create.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

jinja[spacing]

Jinja2 spacing could be improved: {{ create_rds_global_cluster_engine | default('aurora-postgresql')}} -> {{ create_rds_global_cluster_engine | default('aurora-postgresql') }}

Check failure on line 17 in roles/create_rds_global_cluster/tasks/create.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

yaml[comments]

Missing starting space in comment

Check failure on line 17 in roles/create_rds_global_cluster/tasks/create.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

yaml[comments]

Too few spaces before comment
region: "{{ create_rds_global_cluster_primary_cluster_region }}"
engine: "{{ create_rds_global_cluster_engine | default('aurora-postgresql')}}"
engine_version: "{{ create_rds_global_cluster_engine_version | default(omit) }}"
engine_version: "{{ create_rds_global_cluster_engine_version }}"
username: "{{ create_rds_global_cluster_username }}"
password: "{{ create_rds_global_cluster_password }}"
db_subnet_group_name: "{{ create_rds_global_cluster_db_subnet_group_name | default(omit) }}"
Expand All @@ -36,7 +36,7 @@
db_cluster_identifier: "{{ create_rds_global_cluster_replica_cluster_name | default('{{ create_rds_global_cluster_global_cluster_name }}') }}" #aka cluster_name

Check warning on line 36 in roles/create_rds_global_cluster/tasks/create.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

jinja[spacing]

Jinja2 spacing could be improved: {{ create_rds_global_cluster_engine | default('aurora-postgresql')}} -> {{ create_rds_global_cluster_engine | default('aurora-postgresql') }}

Check failure on line 36 in roles/create_rds_global_cluster/tasks/create.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

yaml[comments]

Missing starting space in comment

Check failure on line 36 in roles/create_rds_global_cluster/tasks/create.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

yaml[comments]

Too few spaces before comment
region: "{{ create_rds_global_cluster_replica_cluster_region }}"
engine: "{{ create_rds_global_cluster_engine | default('aurora-postgresql')}}"
engine_version: "{{ create_rds_global_cluster_engine_version | default(omit) }}"
engine_version: "{{ create_rds_global_cluster_engine_version }}"
db_subnet_group_name: "{{ create_rds_global_cluster_db_subnet_group_name | default(omit) }}"
global_cluster_identifier: "{{ create_rds_global_cluster_global_cluster_name }}" # what global db cluster should be associated to

Check failure on line 41 in roles/create_rds_global_cluster/tasks/create.yml

View workflow job for this annotation

GitHub Actions / ansible-lint

yaml[comments]

Too few spaces before comment

Expand Down

0 comments on commit 221fa26

Please sign in to comment.