-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to node20 runtime and resolve bug with Http keepAlive settings #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@divyansh42 are you able to approve this? |
Thanks @adambkaplan @divyansh42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
I am just checking why these tests are not running |
Could you please try to push some changes again so that it triggers the CI checks. Maybe an empty commit |
@divyansh42 maybe there are branch protection rules preventing it these from running? They've not executed for any of my commits so far, I just assumed they were waiting for something (label or otherwise). |
@divyansh42 Looking at previously merged PRs, I'm thinking you maybe have a branch protection rule that depends on this workflow to run and label a PR https://github.com/redhat-actions/openshift-tools-installer/actions/workflows/security_scan.yml - but this workflow is showing as disabled to me. |
@adambkaplan do you want to take a look at the changes once as a few things got changed again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good.
Signed-off-by: Jose R. Gonzalez <[email protected]>
The updated action has been released. |
Description
Bumps runtime environment from Node16 to Node20
Updates @actions/http-client to 2.2.1
Updates code to support the new version of @actions/http-toolkit
Related Issue(s)
Fixes #105
Checklist
Changes made
See above.