Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod crashes while running ods-ci tests for version v2.11.0 #1621

Closed
GunaKKIBM opened this issue Jul 10, 2024 · 8 comments · Fixed by #1622
Closed

Pod crashes while running ods-ci tests for version v2.11.0 #1621

GunaKKIBM opened this issue Jul 10, 2024 · 8 comments · Fixed by #1622
Assignees

Comments

@GunaKKIBM
Copy link

GunaKKIBM commented Jul 10, 2024

Description of problem:

Pod goes to Error status while running the ods-ci tests following this Readme - https://github.com/red-hat-data-services/ods-ci/blob/master/ods_ci/docs/ODS-CI-IMAGE-README.md#running-the-ods-ci-container-image-in-openshift and the following image

quay.io/modh/ods-ci:2.11.0

The issue is - the scripts and test folders are not copied in the expected path.

Prerequisites (if any, like setup, operators/versions):

We have all the pre requisites satisfied. as mentioned here - [https://github.com/red-hat-data-services/ods-ci/blob/master/ods_ci/docs/ODS-CI-IMAGE-README.md#running-the-ods-ci-container-image-in-openshift]

Steps to Reproduce

For both pre requisites and steps to deploy - this doc was being followed, rather than building a custom image - I used quay.io/modh/ods-ci:v2.11.0

Actual results:

RUN SCRIPT ARGS: --test-variables-file /tmp/ods-ci-test-variables/test-variables.yml --skip-oclogin true --set-urls-variables true --include Smoke
ROBOT EXTRA ARGS: -L DEBUG --dryrun
SET TEST ENVIRONMENT: 0
-- USE OCM to install IDPs: 1
-----| ODS-CI is starting the tests run...|-----
./ods_ci/build/run.sh: line 28: ./run_robot_test.sh: No such file or directory

Also. looks like the tests folder isn't copied properly either

skipping OC login as per parameter --skip-oclogin
[ ERROR ] Parsing '/tmp/ods-ci/tests/Tests' failed: File or directory to execute does not exist.

Expected results:
The tests should run and show some results, this is a part of the output is from pod logs from the image that was custom built

Tests.Model Serving.Model Serving Modelmesh
==============================================================================
Verify Model Serving Installation :: Verifies that the core compon... | PASS |
------------------------------------------------------------------------------
Verify Openvino_IR Model Via UI :: Test the deployment of an openv... | PASS |
------------------------------------------------------------------------------
Test Inference Without Token Authentication :: Test the inference ... | PASS |
------------------------------------------------------------------------------
Tests.Model Serving.Model Serving Modelmesh                           | PASS |
3 tests, 3 passed, 0 failed

Reproducibility (Always/Intermittent/Only Once):
Always

Workaround:
Building a custom image with appropriate changes in Dockerfile.

@GunaKKIBM
Copy link
Author

Adding to this, the readme doesn't explain about the variables expected - https://github.com/red-hat-data-services/ods-ci/tree/master?tab=readme-ov-file
A small note about, why these test users and AWS credentials are necessary - what it is referring to, any hyperlink, which suggests what tests are run using these would be helpful - https://github.com/red-hat-data-services/ods-ci/blob/master/ods_ci/test-variables.yml.example

@jiridanek jiridanek linked a pull request Jul 10, 2024 that will close this issue
@CFSNM CFSNM self-assigned this Jul 10, 2024
@CFSNM
Copy link
Contributor

CFSNM commented Jul 10, 2024

@GunaKKIBM Hi, I raised #1622 to fix this issue

@CFSNM
Copy link
Contributor

CFSNM commented Jul 10, 2024

@GunaKKIBM related to your questions:

  1. You are right, the README does not mention anything about the variables expected. We will add information about them, but the expected variables follow the structure of https://github.com/red-hat-data-services/ods-ci/blob/master/ods_ci/test-variables.yml.example

  2. The users are necessary for some of the workbench tests. There are some robot keywords that accept different users to test the operation from the user perspective. E.g.:

    [Arguments] ${workbench_title} ${project_title} ${username}=${TEST_USER_3.USERNAME}

  3. About the AWS credentials, they are used to create data connections for our tests. E.g.:

    ... ${aws_s3_endpoint}=${S3.AWS_DEFAULT_ENDPOINT} ${aws_region}=${S3.AWS_DEFAULT_REGION}

@CFSNM
Copy link
Contributor

CFSNM commented Jul 11, 2024

@GunaKKIBM hey, the images have been rebuild to pickup the fix. Please, let us know if you are still facing some issues

@GunaKKIBM
Copy link
Author

@CFSNM , thanks, the issue is fixed in the latest image. I am currently working using the test variables, if I see any concern there, I will update.

@GunaKKIBM
Copy link
Author

@CFSNM , I would want to understand more on what the users here, is this users of type user.openshift.io/v1 resource in openshift? I understand these values are used for testing, but I am unclear about where these values should be extracted from.

@CFSNM
Copy link
Contributor

CFSNM commented Jul 22, 2024

@GunaKKIBM do you agree to continue the conversation here: #1641?

@GunaKKIBM
Copy link
Author

Hi @CFSNM . Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants