Updated the notebook manifests with 2024b image reference #389
Conversation
dibryant
force-pushed
the
manifest-ds
branch
2 times, most recently
from
a330c89 to
db8ea3a
Compare
|
@dibryant: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hi Diamond, I have two comments:
|
|
/lgtm There are some bits, which needs to be adjust, they would followed up in next set of PR's.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merging to move along the process. |
| @@ -91,143 +91,178 @@ function check_image_variable_matches_name_and_commitref() { | |||
| local expected_build_name # Why some of the images has `-amd64` suffix and others not? | |||
| case "${image_variable}" in | |||
| odh-minimal-notebook-image-n) | |||
| expected_name="odh-notebook-jupyter-minimal-ubi9-python-3.11" | |||
| expected_commitref="release-2024b" | |||
| expected_build_name="jupyter-minimal-ubi9-python-3.9-amd64" | |||
There was a problem hiding this comment.
these aren't correct, similar to other occurrences - though, the CI failed so it's clear and should be fixed in the followup then
Fixes for https://issues.redhat.com/browse/RHOAIENG-12629
Updated the notebook manifests with 2024b and 2024a image references