Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opendatahub.io/dashboard: 'true' label from rstudio ImageSteams #170

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Mar 6, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-3487

This PR removes opendatahub.io/dashboard: 'true' label from rstudio ImageSteams

@openshift-ci openshift-ci bot requested review from dibryant and rkpattnaik780 March 6, 2024 13:17
@jiridanek
Copy link
Member

jiridanek commented Mar 6, 2024

I was wondering why the annotation was not present in https://github.com/opendatahub-io/notebooks to begin with.

Apparently notebook-related annotations are not present in that repo at all

edit: when I say annotation I mean label

@harshad16
Copy link
Member

@atheo89 can you rebase please , thank you

@atheo89
Copy link
Member Author

atheo89 commented Mar 14, 2024

@atheo89 can you rebase please , thank you

Done

Copy link

openshift-ci bot commented Mar 14, 2024

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images cf73b71 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 👍

@openshift-ci openshift-ci bot added the lgtm label Mar 14, 2024
@harshad16 harshad16 merged commit 65082c7 into red-hat-data-services:main Mar 14, 2024
3 of 6 checks passed
Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89 atheo89 deleted the RHOAIENG-3487 branch October 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants