-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove opendatahub.io/dashboard: 'true' label from rstudio ImageSteams #170
Conversation
I was wondering why the annotation was not present in https://github.com/opendatahub-io/notebooks to begin with. Apparently notebook-related annotations are not present in that repo at all edit: when I say annotation I mean label |
@atheo89 can you rebase please , thank you |
Done |
@atheo89: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16, jiridanek, jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to: https://issues.redhat.com/browse/RHOAIENG-3487
This PR removes opendatahub.io/dashboard: 'true' label from rstudio ImageSteams