update: add dependent resources #68
Conversation
zdtsw
requested review from
rareddy,
Jooho,
anishasthana,
VaishnaviHire and
HumairAK
- add missing resoruce in dps - chore fix from naming in ModelReg Signed-off-by: Wen Zhou <[email protected]>
zdtsw
requested review from
dhirajsb
and removed request for
rareddy and
anishasthana
Co-authored-by: Dhiraj Bokde <[email protected]>
Co-authored-by: Dhiraj Bokde <[email protected]>
Co-authored-by: Dhiraj Bokde <[email protected]>
|
@zdtsw MR operator also creates Roles, RoleBindings, and Groups specific to model registry. But, I assume that gathering them will potentially expose user PIA. I don't see other components gathering any security related information either. |
if we need such for specific cases, can ask user to provide them if they are ok to share |
| # for DSP | ||
| resources=("datasciencepipelinesapplications") | ||
| # depedent resources from kubeflow | ||
| resources+=("scheduledworkflows" "viewers") |
| # depedent resources from kubeflow | ||
| resources+=("scheduledworkflows" "viewers") | ||
| # depedent resources from k8s | ||
| resources+=("applications") |
There was a problem hiding this comment.
not sure where this is referenced from, but I don't think we need this
Signed-off-by: Wen Zhou <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
collection-scripts/gather_serving
Outdated
| @@ -2,6 +2,12 @@ | |||
| # shellcheck disable=SC1091 | |||
| source common.sh | |||
| resources=("inferenceservices" "inferencegraphs" "trainedmodels" "servingruntimes" "clusterstoragecontainers" "predictors") | |||
| # Dependent resources ossm | |||
| resources+=("smcp" "smm" "smmr" "gateways" "authorizationpolicies" "envoyfilters") | |||
There was a problem hiding this comment.
The virtualservice is missing. Additionally, it is not possible to gather the secret, correct? This is because we have TLS secrets in place.
There was a problem hiding this comment.
we do not collect secret by default, i wil add virtualservices in the list
Signed-off-by: Wen Zhou <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
depend on #67
also fix comments from ^