Add "--only" option to process only a single rule #6441
+338
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweiske
force-pushed
the
cli-option-only-rule
branch
from
985e2db
to
e5b3888
Compare
|
There should be kind of e2e tests that passes and that fails if data are incorrect |
cweiske
force-pushed
the
cli-option-only-rule
branch
from
e5b3888
to
7de7a84
Compare
|
I've added an end-to-end test that fails when e.g. the ConfigurationRuleFilter simply returns all rectors instead of filtering them. I had to extend the e2eTestRunner to support additional command line options. |
|
Register new e2e path to rector-src/.github/workflows/e2e.yaml Line 26 in 37226f1 |
cweiske
force-pushed
the
cli-option-only-rule
branch
from
7de7a84
to
86e10d9
Compare
|
e2e-test is registered. |
samsonasik
reviewed
Nov 24, 2024
The option for the "process" and "list-rules" commands applies the single given rule only, without needing to modify the configuration file. The option value must be a fully classified class name: --only="Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector" A hint is given when the user forgot to escape the backslashes. ---- It is impossible to modify the injected "$rectors" after the command line configuration is parsed, so I had to introduce the ConfigurationRuleFilter singleton. Since both ListRulesCommand and ProcessCommand make use of the ConfigurationRuleFilter - but list-rules does not have a Configuration - I had to make the filterOnlyRule() method public to prevent code duplication. Resolves rectorphp/rector#8899
cweiske
force-pushed
the
cli-option-only-rule
branch
from
86e10d9
to
19e7820
Compare
|
Code is adjusted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option for the "process" and "list-rules" commands applies the single given rule only, without needing to modify the configuration file.
The option value must be a fully classified class name:
A hint is given when the user forgot to escape the backslashes.
It is impossible to modify the injected "$rectors" after the command line configuration is parsed, so I had to introduce the ConfigurationRuleFilter singleton.
Since both ListRulesCommand and ProcessCommand make use of the ConfigurationRuleFilter - but list-rules does not have a Configuration - I had to make the filterOnlyRule() method public to prevent code duplication.
Resolves rectorphp/rector#8899
Test it: