Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on graph default device #109

Closed
EwanC opened this issue Mar 24, 2023 · 1 comment
Closed

Decide on graph default device #109

EwanC opened this issue Mar 24, 2023 · 1 comment
Labels
Graph Specification Extension Specification related

Comments

@EwanC
Copy link
Collaborator

EwanC commented Mar 24, 2023

Motivated by PR review comment #83 (comment)

With the change in a modifiable graph from being device-agnostic to device-specific, the explicit API now takes an extra device parameter to graph.add(). It may make users lives more ergonomic for the most common single-device use cases if the graph had a default device that nodes were created for, and there was an overload of graph.add() which didn't need the device and used the default device instead.

The open question with this is whether a user should be able to change the default device, or if it's immutable on graph construction.

If a user can't change the default device, then a property to the existing graph constructor would be fine for setting the
default device, since there is no set_property in SYCL. But it would be useful for a user to change the default device, then maybe a set_default_device()/get_default_device() pair of functions would be also be worth adding, as well as overloading the current constructor with command_graph(device) too.

@EwanC
Copy link
Collaborator Author

EwanC commented Mar 28, 2023

Closing, since we'll go with a different approach in revision 1

@EwanC EwanC closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graph Specification Extension Specification related
Projects
None yet
Development

No branches or pull requests

1 participant