Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for New Maintainer #80

Open
ncthbrt opened this issue Jul 5, 2020 · 9 comments
Open

Call for New Maintainer #80

ncthbrt opened this issue Jul 5, 2020 · 9 comments

Comments

@ncthbrt
Copy link
Member

ncthbrt commented Jul 5, 2020

Hi there,
bs-express is looking for a new maintainer. I have been quite passively triaging issues and reviewing PRs, however I am not actively involved in the ReasonML community currently and so have not been keeping up with recent developments or changes to tooling and best practices.

I am happy to continue maintaining this repo in a passive manner, however I believe the project would be better served by someone who is willing to more actively take charge of the project and make more substantive improvements to the ergonomics or design of the library.

Natalie

@austindd
Copy link

@ncthbrt , I would certainly consider taking an active role on this. I'm not sure how much effort I can devote to it, but I can definitely help with some of the maintenance.

I happen to be one of the main authors/maintainers of reason-nodejs, and I have some experience with Express, so it would probably be a natural fit for me.

I'll take a look at the repo. Let me know what you think.

@ncthbrt
Copy link
Member Author

ncthbrt commented Jul 22, 2020

Hi @austindd that'd be fantastic. Please do check it out.

@mweichert
Copy link

@ncthbrt @austindd I'd be happy to help.

make more substantive improvements to the ergonomics or design of the library.

Is there anything in particular you had in mind? I'm relatively new to the ReasonML community, but eager to start contributing in way fashion.

There are some improvements I feel could be made. For instance, Response.sendFile's second parameter is a generic type. I think it would be great if we accepted a some specific type here, and offer a make() function with optional parameters for each configurable key/value pair. That way intellisense / code completion in editors can assist developers when trying to use the sendFile method. I'm not sure if you'd agree if that would be a worthwhile change or not. If so, one concern is backwards compatibility. I'm not too sure how to handle that or what the community expectations would be.

@ncthbrt
Copy link
Member Author

ncthbrt commented Aug 24, 2020

Response.sendFile's second parameter is a generic type. I think it would be great if we accepted a some specific type here
That kind of improvement would certainly help. But I think one of the singularly most effective improvements probably would be some lightweight documentation.

@maxkorp
Copy link
Contributor

maxkorp commented Sep 1, 2020

I use bs-express pretty extensively and would be happy to help out.

@ncthbrt
Copy link
Member Author

ncthbrt commented Jan 29, 2021

@maxkorp Would you still be interested?

@ryyppy
Copy link

ryyppy commented May 15, 2021

I'd like to tune in into this discussion, since we are currently in the process of figuring out what to do with all the active / obsolete projects on the reasonml-community org (which is now a little conflicting after the ReScript rebrand).

If @maxkorp or @austindd would be interested in taking ownership of this whole thing, I'd propose to move this repository over to their personal / business gh organizations, so we can declutter the reasonml-community org from ReScript related content.

Ideally we'd move this repo to a company handle that uses the bindings actively in their product, for a better marketing effect (feels way more stable when a business is backing the development).

Alternatively I may move it over to my personal handle and add you folks as contributors.

What do you think?

PS: There's also a new rescript-express binding by @bloodyowl ... maybe it's even better joining force there?

@ncthbrt
Copy link
Member Author

ncthbrt commented May 17, 2021

I saw that bloody owl had created a new set of bindings. That's awesome. Perhaps then it'd be a better idea to archive this repository and direct people there?

@ryyppy
Copy link

ryyppy commented May 17, 2021

it seems that bloodyowl's approach is geared more towards zero cost bindings, which is a little different to bs-express.

I guess if no one is actively relying on patches to these bindings we could just archive it then... worst case someone will revive the code anyways? I will ask around a little more and see if anyone is willing to take ownership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants