Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification: beta swap template logic fixes #11209

Open
agjohnson opened this issue Mar 12, 2024 · 2 comments · May be fixed by #11543
Open

Notification: beta swap template logic fixes #11209

agjohnson opened this issue Mar 12, 2024 · 2 comments · May be fixed by #11543
Assignees
@agjohnson
Labels
Accepted Accepted issue on our roadmap Bug A bug Improvement Minor improvement to code
Milestone
Template public b...

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Mar 12, 2024 •
edited
Loading

While working on #11208 I found issues likely affecting the beta notification message. Just noting for now:

  • When on the beta dashboard, {{ PRODUCTION_DOMAIN }} is beta.readthedocs.org, not readthedocs.org. The link should use PRODUCTION_DOMAIN|slice:"5:" or similar
  • It's not possible to link to the commercial dashboard beta with simply beta.readthedocs.com/projects/foo, as this will always 404 if the user is not logged in. Instead Add build detail view beta notification #11208 links to the login view first, to ensure the user is always seeing the login first if they are not logged in yet.
  • The header can be conditional too, and "You are using our new beta dashboard" on the beta instance.

This notification is getting into some complex area already, it might be also worth implementing the last part that #11208 added, which was linking to the same url between both dashboards.
@agjohnson agjohnson added the Bug A bug label Mar 12, 2024
@agjohnson agjohnson added the Accepted Accepted issue on our roadmap label Mar 12, 2024
@agjohnson agjohnson mentioned this issue Mar 12, 2024
Merged
@agjohnson agjohnson added the Improvement Minor improvement to code label Mar 12, 2024
@agjohnson agjohnson self-assigned this Mar 26, 2024
agjohnson added a commit that referenced this issue Aug 15, 2024
@agjohnson
First pass fixes for site-wide new dashboard notification
8a4d944 
- Refs #11209
This was referenced Aug 15, 2024
Draft
Merged
@agjohnson
Copy link
Contributor Author

I'm still waiting on this one as we are just getting to testing auth. When we are closer to giving users the new auth pages I'll have more interest in doing this for both sites.

@humitos
Copy link
Member

humitos commented Oct 2, 2024

We have auth pages already working on new web-ext-theme. I'm testing this in https://docs.ops.verbthenouns.com/ for now, and I'm planning to test it on a customer domain next. See https://github.com/readthedocs/readthedocs-corporate-ops/issues/893

It would be good if we can move forward with this, so we can migrate more users to the new templates soon 🎉 . We are pretty close 😄

@ericholscher ericholscher mentioned this issue Nov 4, 2024
Open
agjohnson added a commit that referenced this issue Nov 5, 2024
@agjohnson
First pass fixes for site-wide new dashboard notification
5aac970 
- Refs #11209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agjohnson agjohnson

Labels
Accepted Accepted issue on our roadmap Bug A bug Improvement Minor improvement to code
Projects
📍Roadmap
Status: In progress
Milestone
Template public beta - community
Development

Successfully merging a pull request may close this issue.

Fix site-wide new dashboard notification readthedocs/readthedocs.org
2 participants
@humitos @agjohnson