Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the create play service according to the new platform requirement #38

Open
ammaaraslam opened this issue Jul 2, 2023 · 0 comments · May be fixed by #41 or #44
Open

Update the create play service according to the new platform requirement #38

ammaaraslam opened this issue Jul 2, 2023 · 0 comments · May be fixed by #41 or #44

Comments

@ammaaraslam
Copy link
Member

Due to the recent migration of the ReactPlay platform from CRA to Vite, there's a file convention in Vite that accepts only .jsx, .ts, or .tsx files for React components.

In order to adhere to this, we have to change how JS plays are created. We have to change the current play creation service from creating a .js file to a .jsx file
@ammaaraslam ammaaraslam mentioned this issue Jul 2, 2023
Closed
11 tasks
@ammaaraslam ammaaraslam linked a pull request Jul 23, 2023 that will close this issue
Cra to vite create play service update #41
Open
8 tasks
@ammaaraslam ammaaraslam linked a pull request Jul 23, 2023 that will close this issue
Open
8 tasks
@Angra974 Angra974 mentioned this issue Sep 24, 2023
Closed
11 tasks
@Angra974 Angra974 linked a pull request Oct 13, 2023 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ammaaraslam