Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upload-artifact
). Close Update GH actions to use latest Node #5961 (partially)upload-artifact
was bumped to v3, as I'm not sure about the required unique artifact names in v4, though v3 still uses node16. Also close [Bug]:analyze
workflow fails because of deprecated version ofactions/upload-artifact
#7148Upload analysis comment
step)Analyze Bundle (Comment)
action failure on the default branch by rewriting the condition, as GitHub's runner evaluation is tricky and sometimes provides false positives. Close [GH workflow] updateanalyze.yml
to avoid noisy notification #5801NOTE: analyze-comment depends on
workflow_run
and thus will be used only after merging updates into the default branch. This is why the deprecation warning is still present (https://github.com/reactjs/react.dev/actions/runs/7980542658). To check the proposed fix in a condition, you may look over the same fix in my test repo and then dependant workflow respecting that condition.Thorough review is welcomed, as I'm no GitHub Actions professional :)
UPD
I added folded block to
if
condition without expression to shorten the line, and it seems to work file. Links to my latest test results are updated.