-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hiding of all TabPanels #525
Comments
I don't think the
What do you think about it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Firstly, thanks for this great lib. The focus on a11y is a huge +1.
The UI I'm aiming for is a tab-strip with all the tab panels closed, and a tab is activated only when the user selects a tab. It looks like react-tabs doesn't currently support hiding all the tab panels.
I searched the issues here to find #287, but this seems to be using a CSS-only solution. This will still cause the DOM to have the tab panel. This not only adds unnecessary stuff to the DOM (my tab panel could have a lot of DOM nodes), but also fires off the rendering lifecycle of the tab panel's contents, including all the hooks for that panel. In my case, this would trigger network requests and such, which I would like to avoid.
Would it be possible to build support for something like
defaultIndex={null}
, so that all tab panels can be hidden away until needed?The text was updated successfully, but these errors were encountered: