Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS Enum support #884

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

TS Enum support #884

wants to merge 2 commits into from

Conversation

danez
Copy link
Collaborator

@danez danez commented Dec 22, 2023

Fixes #877

  • Tests for Interfaces, because they might start working unexpectedly
  • Tests for enums
  • implement enums

@danez danez self-assigned this Dec 22, 2023
Copy link

changeset-bot bot commented Dec 22, 2023

⚠️ No Changeset found

Latest commit: 86d0d07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for react-docgen ready!

Name Link
🔨 Latest commit 86d0d07
🔍 Latest deploy log https://app.netlify.com/sites/react-docgen/deploys/6628c65185bea70008ca00d9
😎 Deploy Preview https://deploy-preview-884--react-docgen.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@valentinpalkovic
Copy link

@danez Thank you so much for adding better TS Enum support. Can I somehow help get that over the finish line? Are tests the only part missing to get this merged?

This way we do not have to do major releases that often and could also iterate more on some options.
@rvetere
Copy link
Contributor

rvetere commented Apr 25, 2024

why is this not merged yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better TS enum support
3 participants