-
-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-docgen cannot extract comments with hermes-parser #835
Comments
Interesting, first time I heard about this. I will check, but I'm not confident I can do something from our side. |
I've managed to write an albeit hacky solution to extract component and prop descriptions but now I'm struggling to figure out how to jump cross components to find the spread objects and their descriptions. Can you offer some advice here?
Sadly it seems there's no documentation on handlers (or much else) so I've just been logging the object structure + trying to decipher the default handlers to try get what I need. |
I've just made my component type definition more complicated which has unfortunately broken my own plugin.. The ones written in this lib to handle all other docs still works as expected. Would be so great if they worked on comments 😢 @danez did you get a chance to look into it? |
Component comment blocks as well as proptype comments cannot be extracted with react docgen when using babel hermes-parser plugin https://www.npmjs.com/package/babel-plugin-syntax-hermes-parser. This parser is essential when running an application with flow
This issue explains it a bit more facebook/hermes#1098. Would it be possible to improve the default handlers to support this?
The text was updated successfully, but these errors were encountered: