Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

export ReactChartJs #169

Open
CodePlayer7 opened this issue Dec 28, 2016 · 4 comments · Fixed by atav32/react-chartjs#1
Open

export ReactChartJs #169

CodePlayer7 opened this issue Dec 28, 2016 · 4 comments · Fixed by atav32/react-chartjs#1

Comments

@CodePlayer7
Copy link

CodePlayer7 commented Dec 28, 2016

exports ReactChartJs rather than react-chartjs so we can simply call ReactChartJs rather than window['react-chartjs']

@CodePlayer7 CodePlayer7 changed the title exports ReactChartJs rather than react-chartjs so we can simply call ReactChartJs rather than window['react-chartjs'] export ReactChartJs Dec 28, 2016
@Jareechang
Copy link
Collaborator

@CallMeXYZ, can you provide more details on this issue ?

@CodePlayer7
Copy link
Author

when importing this project by url or cdn, we need to call window['react-chartjs'] to get the reference. If exporting as ReactChartJs then we can simply call ReactChartJs

@morenoh149
Copy link

This seems like a small enough improvement one could submit a PR for. Would one change this file? https://github.com/reactjs/react-chartjs/blob/master/index.js

@Jareechang
Copy link
Collaborator

Hi Everyone, I believe this is specified in webpack and not in the source code itself. I am happy to take PRs.

That being said, my only concern with this request is that it may break other people's projects using window['react-chartjs'] if we change it. Unfortunately, I am a little hesitant with this change.

Please see:

Helpful resource:

Webpack >2.0 Doc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants