Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Process #23

Open
arshadkazmi42 opened this issue Mar 6, 2019 · 3 comments
Open

Review Process #23

arshadkazmi42 opened this issue Mar 6, 2019 · 3 comments

Comments

@arshadkazmi42
Copy link
Member

arshadkazmi42 commented Mar 6, 2019

For reviewing we follow this process.

  • Add the list of all the section names (in english) in the pull request description, which reviewer will mark check as and when the review of each section is getting completed (For reference check this PR [Translation] - Getting Started #17 )
  • You should not resolve review feedback, you can add a comment or an 👍 emoji to every review comment once it's resolved and pushed.
  • A reviewer will review the changes and resolve the conversations

Review Phases

@arshadkazmi42 arshadkazmi42 pinned this issue Mar 6, 2019
@saranshkataria
Copy link
Member

We should also add that if the file is large, add a list of sections so that the reviewer can check the ones we have reviewed?

@arshadkazmi42
Copy link
Member Author

We should also add that if the file is large, add a list of sections so that the reviewer can check the ones we have reviewed?

Added this point also 👍

@saranshkataria
Copy link
Member

Also, try and have the section names in english so as to avoid any confusions if the translation for the heading changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants