-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maven toolchains not used to set the java version #100
Comments
Do you mean to compile your sources? In this case, it reuses the maven compiler configuration. |
No, it's for running my vertx app
|
ah ok. Did you try to change |
The thing is that, we are using toolchains to have hermetic builds. And it works very well. When I set a local Java version using But the question for me was, since maven-toolchains-plugin makes the build of a project really hermetic, and every new developer have only to configure the toolchains, clone the project and that's all, I wanted to know how to. This keep the difference between every developers machine quite minimal. |
The JavaProcessExecutor class could be modified to use the toolchain configure in the tool chain plugin. Fancy a PR? |
First of all, thanks for your work and for this great plugin.
We have multiple JDK versions installed and managed with toolchains plugin in our builds.
Unfortunately, the vertx-maven-plugin doesn't give the possibility of configuring which JDK to use.
Is there any way to do this or can you point me of helping implementing it?
Thanks in advance
The text was updated successfully, but these errors were encountered: