Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing bin/es4x-launcher.jar in Hello World example #575

Closed
tpfau opened this issue Feb 10, 2022 · 4 comments
Closed

Missing bin/es4x-launcher.jar in Hello World example #575

tpfau opened this issue Feb 10, 2022 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@tpfau
Copy link
Contributor

tpfau commented Feb 10, 2022

Hi,
I just wanted to start a new es4x project as indicated in the Hello World example page (here)[https://reactiverse.io/es4x/get-started/hello-world.html#create-a-new-project].
When Calling es4x project I'm getting a "Missing bin/es4x-launcher.jar" message, which I don't really understand. Is this intentional? I noticed the same happened in #545, and it also showed up in the example given by @pmlopes. Actually, when I run it as indicated in the reply, I get an error from npm :

$ npm init @es4x project
Missing bin/es4x-launcher.jar
npm ERR! code 3
npm ERR! path ~/my-app
npm ERR! command failed
npm ERR! command sh -c es4x "project"

which indicates that this missing message is indeed an error.
Am I doing something wrong? Or is this intentional? It's just a very odd message coming up. Seems not to stop development, but maybe it should still be fixed?

@pmlopes
Copy link
Contributor

pmlopes commented Feb 11, 2022

@tpfau this is a non-desired side effect. During the init some validation is run by the launch script which should not be the case. For now, it can be safely ignored, and will go away once a npm install is run.

@tpfau
Copy link
Contributor Author

tpfau commented Feb 11, 2022

Ok. Should I close the issue, or do you want it to stay open till it is fixed by a pr?

@pmlopes
Copy link
Contributor

pmlopes commented Feb 11, 2022

On develop i've replaced the error with just a message to run the install action. Once vertx releases 4.2.5, i'll build an official release and tag this issue on it.

@pmlopes pmlopes added the bug Something isn't working label Feb 11, 2022
@pmlopes pmlopes added this to the 0.17.1 milestone Feb 11, 2022
@pmlopes
Copy link
Contributor

pmlopes commented Feb 11, 2022

Fixed by: a07b5cf

@pmlopes pmlopes closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants