Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable react-error-overlay #11

Open
jedireza opened this issue Feb 4, 2020 · 4 comments
Open

Ability to disable react-error-overlay #11

jedireza opened this issue Feb 4, 2020 · 4 comments

Comments

@jedireza
Copy link

jedireza commented Feb 4, 2020

While refactoring many files one may create compile warnings across multiple files. Because react-error-overlay doesn't let you see the component/fixture you're working on until there are no errors, you can't easily iterate through files one at a time. You have to go fix all the compile errors before viewing the component you're currently working on.

You can inspect the overlay and delete it from the DOM showing the component/fixture you're working on.

@ovidiuch
Copy link
Member

ovidiuch commented Feb 4, 2020

The root issue might be that all fixtures are bundled together, so if you have a compile error in one of your fixtures webpack can't bundle any fixtures.

@jedireza
Copy link
Author

jedireza commented Feb 4, 2020

It's bundling them, but react-error-overlay renders over what's visible in the view port. The same errors are still shown in the dev console. It would be really nice to make this a config setting.

@ovidiuch
Copy link
Member

ovidiuch commented Feb 4, 2020

Can you post a screenshot of the error overlay? I'm curious if it's a compilation error, a module runtime error or a render runtime error. If it's the 1) webpack can't bundle. If it's 3) it only appears on the component that crashes, the rest should load just fine. Maybe it's 2). Or maybe it's some linting/optional errors that I'm not familiar with.

@jedireza
Copy link
Author

jedireza commented Feb 5, 2020

Or maybe it's some linting/optional errors that I'm not familiar with.

It's probably this. IIRC it was some type checking errors. I don't have a screenshot in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants