Remove all agent restart handlers (#396)

* Remove all the handler things

* Remove restart from hardware vendor common tasks

* Remove poller and rsyslogd handlers

* Force maas-restart.yml to always restart all hosts

Author: npawelek

playbooks/common-tasks/maas-host-vendor-dell.yml

@@ -20,8 +20,6 @@
     owner: "root"
     group: "root"
     mode: "0644"
-  notify:
-    - Restart rax-maas
   tags:
     - maas-hosts-vendor-dell
 
@@ -32,8 +30,6 @@
     owner: "root"
     group: "root"
     mode: "0644"
-  notify:
-    - Restart rax-maas
   tags:
     - maas-hosts-vendor-dell
 
@@ -44,7 +40,5 @@
     owner: "root"
     group: "root"
     mode: "0644"
-  notify:
-    - Restart rax-maas
   tags:
     - maas-hosts-vendor-dell

playbooks/common-tasks/maas-host-vendor-hp.yml

@@ -20,8 +20,6 @@
     owner: "root"
     group: "root"
     mode: "0644"
-  notify:
-    - Restart rax-maas
   tags:
     - maas-hosts-vendor-hp
 
@@ -33,7 +31,5 @@
     - "hp-memory"
     - "hp-processors"
     - "hp-vdisk"
-  notify:
-    - Restart rax-maas
   tags:
     - maas-hosts-vendor-hp

playbooks/handlers/main.yml

@@ -134,7 +134,3 @@
     - vars/maas-{{ ansible_distribution | lower }}.yml
   tags:
     - maas-agent-install
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-agent-install.yml

@@ -53,8 +53,6 @@
         times: yes
         rsync_opts:
           - "--no-motd"
-      notify:
-        - Restart rax-maas
 
     - name: Drop in wrapper script to run maas plugins in venv
       template:
@@ -103,8 +101,6 @@
         mode: 0600
         owner: root
         group: root
-      notify:
-        - Restart rax-maas
       when:
         - maas_use_api | bool
 
@@ -116,15 +112,9 @@
       when:
         - maas_use_api | bool
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
     - vars/maas-auth.yml
     - vars/maas-agent.yml
   tags:
     - maas-agent-setup
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-agent-setup.yml

@@ -21,7 +21,6 @@
     - name: Set the current group
       set_fact:
         maas_current_group: mons
-
   tags:
     - maas-ceph-mons
 
@@ -56,16 +55,8 @@
       with_items:
         - ceph_mon_stats
         - ceph_cluster_stats
-      notify:
-        - Restart rax-maas
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
   tags:
     - maas-ceph-mons
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-ceph-mon.yml

@@ -59,16 +59,8 @@
         group: "root"
         mode: "0644"
       delegate_to: "{{ physical_host | default(ansible_host) }}"
-      notify:
-        - Restart rax-maas
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
   tags:
     - maas-ceph-osds
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-ceph-osd.yml

@@ -21,7 +21,6 @@
     - name: Set the current group
       set_fact:
         maas_current_group: rgws
-  
   tags:
     - maas-ceph-rgws
 
@@ -55,16 +54,8 @@
       delegate_to: "{{ physical_host | default(ansible_host) }}"
       with_items:
         - ceph_rgw_stats
-      notify:
-        - Restart rax-maas
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
   tags:
     - maas-ceph-rgws
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-ceph-rgw.yml

@@ -88,18 +88,9 @@
       when:
         - ansible_distribution_version == '14.04'
       delegate_to: "{{ physical_host | default(ansible_host) }}"
-      notify:
-        - Restart rax-maas
-
-  handlers:
-    - include: handlers/main.yml
 
   vars_files:
     - vars/main.yml
     - vars/maas-container.yml
   tags:
     - maas-container-storage
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-container-storage.yml

@@ -21,7 +21,6 @@
     - name: Set the current group
       set_fact:
         maas_current_group: hosts
-
   tags:
     - maas-host-cdm
 
@@ -38,8 +37,6 @@
         mode: "0644"
       with_items:
         - "{{ maas_filesystem_overrides | default(maas_filesystem_monitors) }}"
-      notify:
-        - Restart rax-maas
 
     - name: Install disk utilisation Checks
       template:
@@ -48,8 +45,6 @@
         owner: "root"
         group: "root"
         mode: "0644"
-      notify:
-        - Restart rax-maas
 
     - name: Install memory Checks
       template:
@@ -58,8 +53,6 @@
         owner: "root"
         group: "root"
         mode: "0644"
-      notify:
-        - Restart rax-maas
 
     - name: Install cpu Checks
       template:
@@ -68,18 +61,9 @@
         owner: "root"
         group: "root"
         mode: "0644"
-      notify:
-        - Restart rax-maas
-
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
     - vars/maas-host.yml
   tags:
     - maas-ceph-osds
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-host-cdm.yml

@@ -21,7 +21,6 @@
     - name: Set the current group
       set_fact:
         maas_current_group: hosts
-
   tags:
     - maas-hosts-kernel
 
@@ -36,17 +35,9 @@
         owner: "root"
         group: "root"
         mode: "0644"
-      notify:
-        - Restart rax-maas
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
     - vars/maas-host.yml
   tags:
     - maas-hosts-kernel
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-host-kernel.yml

@@ -21,7 +21,6 @@
     - name: Set the current group
       set_fact:
         maas_current_group: hosts
-
   tags:
     - maas-hosts-network
 
@@ -47,8 +46,6 @@
         mode: "0644"
       with_together:
         - "{{ maas_network_checks_list }}"
-      notify:
-        - Restart rax-maas
 
     - name: Install conntrack count checks
       template:
@@ -57,17 +54,9 @@
         owner: "root"
         group: "root"
         mode: "0644"
-      notify:
-        - Restart rax-maas
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
     - vars/maas-host.yml
   tags:
     - maas-hosts-network
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-host-network.yml

@@ -42,15 +42,9 @@
       with_items:
         - { name: "private_ping_check" }
         - { name: "private_ssh_check" }
-      notify:
-        - Restart rax-maas
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
     - vars/maas-poller.yml
   tags:
     - maas-poller-setup
-
-- include: maas-restart.yml

playbooks/maas-host-private-checks.yml

@@ -35,13 +35,7 @@
         - maas_host_check | bool
         - ansible_system_vendor.split()[0] | lower == 'dell'
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
   tags:
     - maas-hosts-vendor
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-host-vendor.yml

@@ -21,7 +21,6 @@
     - name: Set the current group
       set_fact:
         maas_current_group: elasticsearch_all
-
   tags:
     - maas-infra-elasticsearch
 
@@ -37,17 +36,9 @@
         group: "root"
         mode: "0644"
       delegate_to: "{{ physical_host | default(ansible_host) }}"
-      notify:
-        - Restart rax-maas
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
     - vars/maas-infra.yml
   tags:
     - maas-infra-elasticsearch
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml

playbooks/maas-infra-elasticsearch.yml

@@ -21,7 +21,6 @@
     - name: Set the current group
       set_fact:
         maas_current_group: hosts
-
   tags:
     - maas-infra-filebeat
 
@@ -40,17 +39,9 @@
       when:
         - "'elasticsearch_all' in groups"
         - groups['elasticsearch_all'] | length > 0
-      notify:
-        - Restart rax-maas
 
-  handlers:
-    - include: handlers/main.yml
   vars_files:
     - vars/main.yml
     - vars/maas-infra.yml
   tags:
     - maas-infra-filebeat
-
-# NOTE(cloudnull): When we get to ONLY using Ansible 2.2+ this playbook can be removed as the handler
-#                  will be globally unified.
-- include: maas-restart.yml