-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Bot Token instead of Webhook URL #122
Comments
Hello and welcome to RavSam 💜. Thanks for opening your first issue. I will assign one of our team members to take a look at the problem you have raised. Make sure to include as much information as possible to help our team diagnose the issue and solve it quickly. If the problem is related to a security concern, then please delete this issue and send us an email at [email protected]. |
Hello! 👋 I’ve already created a PR with all the code changes related to this request, as I ran into the same issue and wanted to implement the support for Slack Bot Tokens. Could I please get access to push the changes? Thanks in advance! 😊 |
@ManuelNemirovsky Thanks for your work. Are you not able to open a PR? |
@ravgeetdhillon Yes, I believe there is a block defined in the repository ERROR: Permission to ravsamhq/notify-slack-action.git denied to ManuelNemirovsky.
fatal: Could not read from remote repository. |
Webhook Urls are tied to a slack channel and thus are not very flexible.
Using slack bot tokens this could be easily fixed.
I already tried to make a PR, but since i am not that familiar with node projects, i failed to release a test version.
In essence one only has to POST to https://slack.com/api/chat.postMessage with the bot token as Bearer and the channel id in the body.
I could see you guys supporting both with minimal effort by modifying buildPayload and notifySlack methods
My inspiration came from https://github.com/devkyt/slack-send-msg and several other implementations. However they do not offer such a nice message API as you guys do, so i would rather contribute here.
The text was updated successfully, but these errors were encountered: