Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selected control protocol to HA discovery message payload #75

Open
Goose66 opened this issue Jan 28, 2024 · 2 comments
Open

Add selected control protocol to HA discovery message payload #75

Goose66 opened this issue Jan 28, 2024 · 2 comments

Comments

@Goose66
Copy link

Goose66 commented Jan 28, 2024

Could the configured control mode be added to the discovery payload? Perhaps something like:

{
  "~": "ratgdo-41533",
  "name": "Door",
...
  "device": {
    "name": "ratgdo-41533",
    "identifiers": "ratgdo-41533_C8:C9:A3:18:F1:04",
    "manufacturer": "Paul Wieland",
    "model": "ratgdo",
    "sw_version": "2.57",
    "configuration_url": "http://192.168.1.109/",
    "control_protocol": "drycontact"  # <---- add this or "secplus1" or "secplus2" etc. 
  }
}

This would help my UDI Polyglot plugin better understand the capabilities of the ratgdo device with the connected GDO. I do appreciate the change already in place to only publish the light discovery messages if not "drycontact" mode.

@Goose66
Copy link
Author

Goose66 commented Jan 29, 2024

I suppose if adding a new key would upset HomeAssistant for some reason, it could always be added to the "model" value, e.g.:
"model": "ratgdo-drycontact"

@Goose66
Copy link
Author

Goose66 commented Jan 30, 2024

Alternatively, perhaps a REST interface at the configuration_url I could read to get the control protocol, if that is easier (or already exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant