Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonesense message in pico_extras_import.cmake #39

Open
smithps opened this issue Jul 19, 2022 · 4 comments
Open

nonesense message in pico_extras_import.cmake #39

smithps opened this issue Jul 19, 2022 · 4 comments

Comments

@smithps
Copy link

smithps commented Jul 19, 2022

Line 53 has the message;

"PICO EXTRAS location was not specified. Please set PICO_EXTRAS_PATH or set PICO_EXTRAS_FETCH_FROM_GIT to on to fetch from git."
should it really be;

... PICO_EXTRAS_FETCH_FROM_GIT to fetch from git.

@lurch
Copy link
Contributor

lurch commented Jul 19, 2022

It defaults to being 'off', so you have to set it 'on' to make use of that feature? 🤷 https://github.com/raspberrypi/pico-extras/blob/master/external/pico_extras_import.cmake#L52

@smithps
Copy link
Author

smithps commented Jul 19, 2022

It defaults to being 'off', so you have to set it 'on' to make use of that feature? 🤷 https://github.com/raspberrypi/pico-extras/blob/master/external/pico_extras_import.cmake#L52

Ahhhh !!! now the message makes sense. I would suggest phrasing the message as such though; changing the 'on' in the message to 'ON'

PICO EXTRAS location was not specified. Please set PICO_EXTRAS_PATH or set PICO_EXTRAS_FETCH_FROM_GIT to ON to fetch from git.

Perhaps autocorrect somewhere along the line made it lowercase - because of that I didn't read it as intended.

I also misquoted the line number, but I meant the message as quoted above.

@JamesH65
Copy link
Contributor

I agree with @smithps, changing to "ON" would make that a lot clearer.

@lurch
Copy link
Contributor

lurch commented Jul 19, 2022

Feel free to submit a PR @smithps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants