-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nonesense message in pico_extras_import.cmake #39
Comments
It defaults to being 'off', so you have to set it 'on' to make use of that feature? 🤷 https://github.com/raspberrypi/pico-extras/blob/master/external/pico_extras_import.cmake#L52 |
Ahhhh !!! now the message makes sense. I would suggest phrasing the message as such though; changing the 'on' in the message to 'ON' PICO EXTRAS location was not specified. Please set PICO_EXTRAS_PATH or set PICO_EXTRAS_FETCH_FROM_GIT to ON to fetch from git. Perhaps autocorrect somewhere along the line made it lowercase - because of that I didn't read it as intended. I also misquoted the line number, but I meant the message as quoted above. |
I agree with @smithps, changing to "ON" would make that a lot clearer. |
Feel free to submit a PR @smithps |
Line 53 has the message;
"PICO EXTRAS location was not specified. Please set PICO_EXTRAS_PATH or set PICO_EXTRAS_FETCH_FROM_GIT to on to fetch from git."
should it really be;
... PICO_EXTRAS_FETCH_FROM_GIT to fetch from git.
The text was updated successfully, but these errors were encountered: