Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Make use of cached_property in Cython classes once we update beyond 3.0.11 #16748

Open
vyasr opened this issue Sep 4, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@vyasr
Copy link
Contributor

vyasr commented Sep 4, 2024

Is your feature request related to a problem? Please describe.
Currently various cdef classes in cudf and pylibcudf do not leverage caching as much as they could. This is because, until recently, Cython did not support the cached_property decorator on cdef classes. This feature was implemented in cython/cython#6179 and should be available in the next Cython release, either 3.0.12 or 3.1.0.

Describe the solution you'd like
Once cudf updates to requiring a sufficiently new version of Cython to build, we should start using cached_property. One of the first places this could be used is in the OrcColumnStatistics class in pylibcudf (see https://github.com/rapidsai/cudf/pull/16042/files/4328460b9f9eeaf88417d616f76a006c6e6e5ca8#r1741811824).

Describe alternatives you've considered
We could manually cache the values quite easily, but since the Cython feature is nearly available we may as well wait and save ourselves the effort.

@vyasr vyasr added the feature request New feature or request label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant