-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitles don't like parentheses #174
Comments
It does make sense and I do know why this happens, the new-submaker code isn't great; I mostly got it from a PR I initially merged to master but it had too many issues that I just decided to not bother with it. I intend to redo it at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
New to GitHub so apologies if my terminology isn't correct.
I am using your latest update in "new-submaker" and mostly works great, but if the input text file contains a parentheses"(" or ")" right before the pattern character used for splitting, it stops outputting the subtitle right after that character.
E.g. if text file contains "Hello mate (friend). How are you?" it will stop right after (friend)
It also seems to happen if it's curly brackets {} aswel as parentheses.
Hope this makes sense.
The text was updated successfully, but these errors were encountered: