Skip to content

Conversation

@galal-hussein
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 26.66667% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.49%. Comparing base (30217df) to head (17d42b8).
⚠️ Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/cluster/service.go 25.71% 52 Missing ⚠️
main.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
- Coverage   52.85%   52.49%   -0.37%     
==========================================
  Files          52       53       +1     
  Lines        6385     6460      +75     
==========================================
+ Hits         3375     3391      +16     
- Misses       2749     2806      +57     
- Partials      261      263       +2     
Flag Coverage Δ
cli 51.07% <26.66%> (-0.20%) ⬇️
controller 51.26% <26.66%> (-0.55%) ⬇️
e2e 51.26% <26.66%> (-0.55%) ⬇️
unit 41.33% <0.00%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@enrichman enrichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it looks good! I've left a few comments from my first pass. Let's sync up again after you've had a chance to address the changes. Let me know if you have any questions!

Copy link
Collaborator

@enrichman enrichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments! I would not add a new package if the func are used just in one place, or just in this package.

Signed-off-by: galal-hussein <[email protected]>
@galal-hussein galal-hussein merged commit 0bd681a into rancher:main Oct 1, 2025
6 checks passed
@galal-hussein galal-hussein deleted the lb_service_sync branch October 18, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants