-
Notifications
You must be signed in to change notification settings - Fork 57
Lb service status sync #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
galal-hussein
commented
Sep 2, 2025
- Sync service LoadBalancer IP back #365
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
- Coverage 52.85% 52.49% -0.37%
==========================================
Files 52 53 +1
Lines 6385 6460 +75
==========================================
+ Hits 3375 3391 +16
- Misses 2749 2806 +57
- Partials 261 263 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
69370ee to
fc10703
Compare
enrichman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, it looks good! I've left a few comments from my first pass. Let's sync up again after you've had a chance to address the changes. Let me know if you have any questions!
enrichman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments! I would not add a new package if the func are used just in one place, or just in this package.
Signed-off-by: galal-hussein <[email protected]>
94a53d5 to
66ccfbb
Compare
Signed-off-by: galal-hussein <[email protected]>
Signed-off-by: galal-hussein <[email protected]>