Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures when Activating / Deactiving a Feature Flag are ignored #11167

Open
richard-cox opened this issue Jun 4, 2024 · 1 comment · May be fixed by #13090
Open

Failures when Activating / Deactiving a Feature Flag are ignored #11167

richard-cox opened this issue Jun 4, 2024 · 1 comment · May be fixed by #13090
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.11.0

Comments

@richard-cox
Copy link
Member

Setup

  • Rancher version: 2.8-head

Describe the bug

  • If the request to change a feature flag fails the user is shown the http error response in the modal, however the underlying feature flag state shows as changed
  • Refreshing the page shows the correct state

To Reproduce

  • To fill in

Result

  • To fill in

Expected Result

  • To fill in

Screenshots
image

Additional context
@richard-cox richard-cox added this to the v2.9.next1 milestone Jun 4, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jun 4, 2024
@gaktive gaktive modified the milestones: v2.9.next1, v2.10.0 Jul 2, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@gaktive
Copy link
Member

gaktive commented Nov 1, 2024

Will hold off on backporting until we know which version we address this in and the type of solution required.

@nwmac nwmac linked a pull request Jan 14, 2025 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

Fix state is not reset when feature flag API request fails nwmac/dashboard
3 participants
@nwmac @gaktive @richard-cox