Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge background color doesn't change from Explore/Edit Cluster Badge #10674

Open
momesgin opened this issue Mar 21, 2024 · 4 comments
Open

Badge background color doesn't change from Explore/Edit Cluster Badge #10674

momesgin opened this issue Mar 21, 2024 · 4 comments
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this size/2 Size Estimate 2
Milestone

Comments

@momesgin
Copy link
Member

momesgin commented Mar 21, 2024

Setup

  • Rancher version: 2.9-head

Describe the bug

When customizing the badge background color of a cluster during its creation process, the color becomes visible correctly after the cluster transitions to the active state. However, if you navigate to the cluster's explorer page and click on 'Edit Cluster Badge' to change the color again, it does not update as expected.

Note: You can still set color via 'Edit Cluster Badge' button in the cluster explorer if you didn’t set it during cluster creation.

To Reproduce

  1. Start creating a new cluster with any provider
  2. Write at least three letters for its name to enable 'Customize', then click on it to open the modal
  3. Change the badge background color and click the Apply button
  4. Wait until the cluster becomes active, then go to its Explorer page and Click on 'Edit Cluster Badge'
  5. Change the badge background color again and click the Apply button

Result

  • Badge color should get updated

Expected Result

  • Badge color stays the same

Screenshots

badge-color.mov

Additional context

This issue is probably related to the explorer button using v3 clusters. We have an open issue about syncing between the different cluster objects #9563

@github-actions github-actions bot added [zube]: To Triage QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this and removed [zube]: To Triage labels Mar 21, 2024
@momesgin momesgin changed the title Badge Background Color Doesn't Change From Explore/Edit Customized Badge Badge Background Color Doesn't Change From Explore/Edit Cluster Badge Mar 21, 2024
@momesgin momesgin changed the title Badge Background Color Doesn't Change From Explore/Edit Cluster Badge Badge background color doesn't change from Explore/Edit Cluster Badge Mar 21, 2024
@gaktive gaktive modified the milestones: v2.10.0, v2.9.0 May 13, 2024
@gaktive
Copy link
Member

gaktive commented May 29, 2024

It's possible that we're either not setting or looking properly to the management cluster. Perhaps we're setting that this is set on the provisioning cluster and we're expecting a background process to then sync to the management cluster.

@gaktive
Copy link
Member

gaktive commented May 29, 2024

This may be a possible regression so if we can't solve this for 2.9.0, we may have to remove the option to set the colour badge on creation until we sort this out.

@gaktive gaktive added the size/2 Size Estimate 2 label May 29, 2024
@jordojordo
Copy link
Member

Upon some initial testing, this doesn't appear to be a frontend issue. The request is being sent properly with the correct response from the backend, but the annotation does not appear to be saved. This applies to all of the annotations for the badge ui.rancher/badge*. I could not find any errors in the server logs either.

You can manually create the request from the /v3/clusters/<cluster-id> endpoint of your cluster:

badge-anno.mp4

@gaktive gaktive modified the milestones: v2.9.0, v2.10.0 Jun 18, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@gaktive gaktive modified the milestones: v2.11.0, v2.10.0 Jul 4, 2024
@gaktive
Copy link
Member

gaktive commented Oct 2, 2024

Need to file a backend ticket for this.

@gaktive gaktive modified the milestones: v2.10.0, v2.11.0 Oct 2, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this size/2 Size Estimate 2
Projects
None yet
Development

No branches or pull requests

4 participants