Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out LedgerClient and execute function? #4

Open
mattyg opened this issue Jan 14, 2024 · 3 comments
Open

Pull out LedgerClient and execute function? #4

mattyg opened this issue Jan 14, 2024 · 3 comments

Comments

@mattyg
Copy link
Collaborator

mattyg commented Jan 14, 2024

I'm wondering it makes sense to keep this crate purely for typecasting between alloy and ethers, and pull out the functionality under LedgerClient and ExecutableTransaction.execute into another crate. Maybe keep both crates in this repo as the abstraction layer for working with alloy / ethers to simplify the transition between them?

@hardyjosh @thedavidmeister

@hardyjosh
Copy link
Contributor

I was already hoping to use it in rain.interpreter actually - I was working on adding a ReadableTransction in this repo.

Why did you want to move it out?

@mattyg
Copy link
Collaborator Author

mattyg commented Jan 14, 2024

Why did you want to move it out?

just thinking of separating concerns: keep one crate purely for the ethers <-> alloy typecasting, and make another for the higher-level abstractions for using ethers/alloy in real-world settings (i.e setting up a ledger client, executing a transaction with feedback logs, etc.)

@hardyjosh
Copy link
Contributor

Does make sense actually. The reason we put it here is because it's an alloy interface to what is ethers under the hood. Once it becomes all alloy we'll still want it separated but it won't have an ethers component anymore. Unless @thedavidmeister disagrees I think go ahead and separate out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants