Merge pull request #105 from railsbump/fixes/issue-104-slug-taken

Redirect to existing slug when Gemfile.lock content has been already processed

Author: etagwerker

app/models/lockfile.rb

@@ -30,6 +30,10 @@ def gem_names
     parser.dependencies.keys - %w(rails)
   end
 
+  def calculated_slug
+    ActiveSupport::Digest.hexdigest(gem_names.join("#"))
+  end
+
   private
 
   def add_gemmies
@@ -45,7 +49,7 @@ def add_gemmies
   def generate_slug
     return if self.slug.present?
 
-    self.slug = ActiveSupport::Digest.hexdigest(gem_names.join("#"))
+    self.slug = calculated_slug
   end
 
   def validate_content

app/services/lockfiles/create.rb

@@ -21,15 +21,11 @@ def call(content)
     def build(content)
       result = Lockfile.new(content: content)
 
-      if result.valid?
-        if existing_lockfile = Lockfile.find_by(slug: result.slug)
-          raise AlreadyExists.new(existing_lockfile)
-        end
-
-        result
-      else
-        result
+      if existing_lockfile = Lockfile.find_by(slug: result.calculated_slug)
+        raise AlreadyExists.new(existing_lockfile)
       end
+
+      result
     end
   end
 end