-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rails solid_queue:install:migrations is not a valid command #419
Comments
Similar to this issue, the |
@Juksefantomet, right. That's on purpose, it's not a provided command.
Why would you run it repeatedly?
@n-studio that's on purpose. |
@rosa But then running |
My bad then, i was not catching on that that install:migrations was removed: https://github.com/rails/solid_queue/blob/main/UPGRADING.md As per the above link the upgrade says the binstub was introduced, but the old previous one was not removed 😄 In regards to the duplicate config entry: A few cases can have individuals running a command repeatedly. When a member of our team pulls the project for the first time. They might have issues with their setup, not necessarily related to that gem and/or initialization specifically. But they decide to re-run steps as a part of their troubleshooting. This can also occur when you remove a gem and you decide to re initialize the setup. It's not expected to manually revert a config but expected to the config to be detected and not appended in duplicate entries. Additionally the generator specifically states "gsub" in the production.rb file. I would assume it replaces if present and append if not present. |
What do you mean? 🤔 I'm not sure I follow. The binstub there refers to About the duplicate config entry, there's a PR to make it idempotent: #349. I'll finish that and will merge it soon, I'm just not clear yet about the approach. |
Without overcomplicating this too much 😄 The overall results when I was googling / researching setting up solid_queue which led me to the migrations line for initialization (which is meant for another purpose not initialization and/or first setup?). As pr. the link provided that was where I ended up when i was trying to get everything to work. When trying to setup things one ends up removing / resetting so it was a result of multiple attempts leading to both scenarios. |
I fixed the duplication when running the installer multiple times in #439, and included it in the last version, 1.1.0, so I'm closing this one. |
What command should we run to generate our migration files then? |
@jaspervanbrian, you don't need to generate migration files for Solid Queue, the schema file that gets copied when installing it is enough to create the DB and the tables. |
@rosa, I guess issue rails/rails#52829 still persists. I'm running two db (postgres as my main and sqlite as my secondary for caching), and schema files are not being generated. |
Running rails solid_queue:install:migrations is not a valid command.
Running rails solid_queue:install works - BUT - if ran repeatedly it adds more entries to config/environments/production.rb
so you'll end up with multiple declarations 😄
rails: 8.0.0
ruby: 3.3.6
ubuntu/WSL
The text was updated successfully, but these errors were encountered: