Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Lazy Loading Chained where calls #408

Open
jlurena opened this issue Nov 13, 2024 · 2 comments · May be fixed by #422
Open

[Feature Request] Lazy Loading Chained where calls #408

jlurena opened this issue Nov 13, 2024 · 2 comments · May be fixed by #422

Comments

@jlurena
Copy link

jlurena commented Nov 13, 2024

Summary

I would like assistance implementing lazy HTTP calls for Collections.

Currently doing something like this:

# This makes two API calls.
result = MyActiveResourceModel.where(first_name: "John").where(last_name: "Doe")

Ideal scenario would be that:

# This makes 0 API call
result = MyActiveResourceModel.where(first_name: "John").where(last_name: "Doe")

# This makes 1 API call
result.to_a

# This makes 1 API call
result.any?
@jlurena jlurena mentioned this issue Nov 23, 2024
Closed
@jlurena
Copy link
Author

jlurena commented Nov 24, 2024 •
edited
Loading

@byroot @rails I created a PR, would you mind having a look?

@jlurena
Copy link
Author

jlurena commented Dec 2, 2024

Bump

seanpdoyle added a commit to seanpdoyle/activeresource that referenced this issue Jan 27, 2025
@seanpdoyle
Introduce ActiveResource::WhereClause
50a401b 
Closes [rails#408][]

Introduce a simple chainable `WhereClause` class inspired by [Active
Record][].

All methods (including those that integrate with [Enumerable][]) are
delegated to `WhereClause#all`, which itself delegates to `Base.find`.

By merging parameters through `.where`-chaining, this commit supports
deferred fetching:

```ruby
people = Person.where(id: 2).where(name: "david")
  # => GET /people.json?id=2&name=david

people = Person.where(id: 2).all(params: { name: "david" }, from: "/records.json")
  # => GET /records.json?id=2&name=david
```

[rails#408]: rails#408
[Active Record]: https://github.com/rails/rails/blob/main/activerecord/lib/active_record/relation/where_clause.rb
[Enumerable]: https://ruby-doc.org/3.4.1/Enumerable.html
seanpdoyle added a commit to seanpdoyle/activeresource that referenced this issue Jan 27, 2025
@seanpdoyle
Introduce ActiveResource::WhereClause
62d9a30 
Closes [rails#408][]

Introduce a simple chainable `WhereClause` class inspired by [Active
Record][].

All methods (including those that integrate with [Enumerable][]) are
delegated to `WhereClause#all`, which itself delegates to `Base.find`.

By merging parameters through `.where`-chaining, this commit supports
deferred fetching:

```ruby
people = Person.where(id: 2).where(name: "david")
  # => GET /people.json?id=2&name=david

people = Person.where(id: 2).all(params: { name: "david" }, from: "/records.json")
  # => GET /records.json?id=2&name=david
```

[rails#408]: rails#408
[Active Record]: https://github.com/rails/rails/blob/main/activerecord/lib/active_record/relation/where_clause.rb
[Enumerable]: https://ruby-doc.org/3.4.1/Enumerable.html
seanpdoyle added a commit to seanpdoyle/activeresource that referenced this issue Jan 27, 2025
@seanpdoyle
Introduce ActiveResource::WhereClause
c961b31 
Closes [rails#408][]

Introduce a simple chainable `WhereClause` class inspired by [Active
Record][].

All methods (including those that integrate with [Enumerable][]) are
delegated to `WhereClause#all`, which itself delegates to `Base.find`.

By merging parameters through `.where`-chaining, this commit supports
deferred fetching:

```ruby
people = Person.where(id: 2).where(name: "david")
  # => GET /people.json?id=2&name=david

people = Person.where(id: 2).all(params: { name: "david" })
  # => GET /people.json?id=2&name=david

people = Person.all(from: "/records.json").where(id: 2)
  # => GET /records.json?id=2
```

[rails#408]: rails#408
[Active Record]: https://github.com/rails/rails/blob/main/activerecord/lib/active_record/relation/where_clause.rb
[Enumerable]: https://ruby-doc.org/3.4.1/Enumerable.html
seanpdoyle added a commit to seanpdoyle/activeresource that referenced this issue Jan 27, 2025
@seanpdoyle
Introduce ActiveResource::WhereClause
9cb81da 
Closes [rails#408][]

Introduce a simple chainable `WhereClause` class inspired by [Active
Record][].

All methods (including those that integrate with [Enumerable][]) are
delegated to `WhereClause#all`, which itself delegates to `Base.find`.

By merging parameters through `.where`-chaining, this commit supports
deferred fetching:

```ruby
people = Person.where(id: 2).where(name: "david")
  # => GET /people.json?id=2&name=david

people = Person.where(id: 2).all(params: { name: "david" })
  # => GET /people.json?id=2&name=david

people = Person.all(from: "/records.json").where(id: 2)
  # => GET /records.json?id=2
```

[rails#408]: rails#408
[Active Record]: https://github.com/rails/rails/blob/main/activerecord/lib/active_record/relation/where_clause.rb
[Enumerable]: https://ruby-doc.org/3.4.1/Enumerable.html
@seanpdoyle seanpdoyle linked a pull request Jan 27, 2025 that will close this issue
Open
seanpdoyle added a commit to seanpdoyle/activeresource that referenced this issue Jan 27, 2025
@seanpdoyle
Introduce ActiveResource::WhereClause
d86b0d0 
Closes [rails#408][]

Introduce a simple chainable `WhereClause` class inspired by [Active
Record][].

All methods (including those that integrate with [Enumerable][]) are
delegated to `WhereClause#all`, which itself delegates to `Base.find`.

By merging parameters through `.where`-chaining, this commit supports
deferred fetching:

```ruby
people = Person.where(id: 2).where(name: "david")
  # => GET /people.json?id=2&name=david

people = Person.where(id: 2).all(params: { name: "david" })
  # => GET /people.json?id=2&name=david

people = Person.all(from: "/records.json").where(id: 2)
  # => GET /records.json?id=2
```

[rails#408]: rails#408
[Active Record]: https://github.com/rails/rails/blob/main/activerecord/lib/active_record/relation/where_clause.rb
[Enumerable]: https://ruby-doc.org/3.4.1/Enumerable.html
seanpdoyle added a commit to seanpdoyle/activeresource that referenced this issue Jan 27, 2025
@seanpdoyle
Introduce ActiveResource::WhereClause
6acb99d 
Closes [rails#408][]

Introduce a simple chainable `WhereClause` class inspired by [Active
Record][].

All methods (including those that integrate with [Enumerable][]) are
delegated to `WhereClause#all`, which itself delegates to `Base.find`.

By merging parameters through `.where`-chaining, this commit supports
deferred fetching:

```ruby
people = Person.where(id: 2).where(name: "david")
  # => GET /people.json?id=2&name=david

people = Person.where(id: 2).all(params: { name: "david" })
  # => GET /people.json?id=2&name=david

people = Person.all(from: "/records.json").where(id: 2)
  # => GET /records.json?id=2
```

[rails#408]: rails#408
[Active Record]: https://github.com/rails/rails/blob/main/activerecord/lib/active_record/relation/where_clause.rb
[Enumerable]: https://ruby-doc.org/3.4.1/Enumerable.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce ActiveResource::WhereClause seanpdoyle/activeresource
1 participant
@jlurena