Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up img folder #359

Open
alicetragedy opened this issue Feb 16, 2017 · 16 comments
Open

Clean up img folder #359

alicetragedy opened this issue Feb 16, 2017 · 16 comments

Comments

@alicetragedy
Copy link
Member

Our img folder is starting to get a little messy — most of the images under /blog are under control, but the rest is a bit all over the place, named at random, and generally it's difficult to have an overview of where to find the images needed e.g. all assets for the landing page, like the star icon or the header image, could go into a landing-page folder.
We don't currently have a system, and I'm totally open to suggestions on this, I'd just love to have it all a little more organised so that we can find images and assets quickly :)

@alicetragedy
Copy link
Member Author

I've just marked this as beginner-friendly, because I think someone unfamiliar with the codebase or the program's structure can still help. If you're interested, just ping me or leave comments with suggestions on how to structure the folder.
Contributions by first-time contributors are particularly welcome ❤️

@mercykinoti
Copy link

mercykinoti commented Aug 29, 2017 via email

@alicetragedy
Copy link
Member Author

@mercykinoti are you interested in working on this issue?

@alicetragedy
Copy link
Member Author

@chantal66 I saw a notification about you being interested in this issue. It's still not taken, so if you want to work on this, I'd be happy to help get you started!

@chantal66
Copy link
Contributor

Hi @alicetragedy, I would love to contribute. I’m a first-time contributor and was hoping to help out with this issue. Do you have any guidelines on how the images folder should be?

@alicetragedy
Copy link
Member Author

hey @chantal66, that's great, we are always happy about first-time contributors ❤️
I currently don't have any guidelines on how the images folder should be. Suggestions are more than welcome, but if you don't have any, or if you'd prefer having a bit more guidance, we could bounce some ideas back and forth? What do you think? I like the idea of separating by context, e.g. we have a separate folder blog for all of the images that go into the blog.
If you like this idea as well, I'd say the first step would be to look at the current “loose” images in the img folder and see whether any of them fit into the currently existing structure (we have, for example, a scribbles folder and a “loose” image named scribbles-frontpage.png) and move them there and update the links.

@chantal66
Copy link
Contributor

yes.. I was just checking the 'loose' images and see where they could belong.. also sponsors folder could use some sub-directories and grouped them by platinum, gold, silver, etc like you have them on the website.. so it's easier to find when in need... is this the kind of structure u would like to have?

@alicetragedy
Copy link
Member Author

yes, that sounds great @chantal66! 🙌
please let me know if you need any more input, but otherwise I'd say that you go ahead and get started with those.

@chantal66
Copy link
Contributor

I think i'm good. I'll start right away.. thank you! 😄

alicetragedy added a commit that referenced this issue Dec 21, 2017
fixes => Clean up img folder Issue #359
@Paarmita
Copy link

Paarmita commented Jan 9, 2018

Hi @alicetragedy,.Is this issue still open? Can i contribute?

@alicetragedy
Copy link
Member Author

alicetragedy commented Jan 11, 2018

hey @Paarmita, yes, this issue is still open. @chantal66 did a bit of work on it, and cleaned up the folder quite a bit, but I think we could still improve on it. All the comments I left in this issue are still valid, so you can read through the thread and let me know if you have any questions? Does that work for you? Let me know if you'd like more help at any point, or if anything is confusing! We're always happy about new contributors!

@Paarmita
Copy link

@alicetragedy I have read the threads and can work on it.

@alicetragedy
Copy link
Member Author

that's great @Paarmita! Just ping me if you need anything.

@Paarmita
Copy link

Paarmita commented Jan 11, 2018

@alicetragedy I am working on sponsers folder. So i just have to remove unused icons?

@alicetragedy
Copy link
Member Author

@Paarmita yes, you can remove unused images, if there are any. (I think there are a lot of images in there from sponsors of past years, which I think can be removed).

@rishi-raj-jain
Copy link
Contributor

I'd like to take up the issue.
Though I've read through the comments but would be more easier if you may summarize about what's to be done apart from removing the unused images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants