Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve styling of single blog posts #273

Open
alicetragedy opened this issue Aug 14, 2016 · 10 comments
Open

improve styling of single blog posts #273

alicetragedy opened this issue Aug 14, 2016 · 10 comments

Comments

@alicetragedy
Copy link
Member

There are a couple of things that could be improved in the current blog:

  • The margins of text above and under images are still not optimal in blog posts; it would be great to give the images a bit more breathing room (keeping in mind that images will usually have a description right underneath which needs to stay where it is).
  • Some guest authors add a lot of inline styles to a post, which is obviously really ugly. Adding a couple of classes on divs and images (that do simple things like centering, changing the image width) might help avoid that in the future.
@acnagy
Copy link
Collaborator

acnagy commented May 31, 2017

🙋 I can take this one! I'm getting started with the codebases, so per some chatter with @alicetragedy, it seems like a good place to start. Plus, yay for more ❤️s to the blog.

Of course, if anyone has additional requests/suggestions since August last year, please do drop them in here

@alicetragedy
Copy link
Member Author

Awesome, I think the first point is definitely the most important, it would make a huge difference right away. Thank you! ✨

@Paarmita
Copy link

@alicetragedy can I work on this issue? I need some help on how to proceed :)

@alicetragedy
Copy link
Member Author

@acnagy do you still have time to work on this, or are you too busy? Can we reassign it to someone else? ✨

@acnagy
Copy link
Collaborator

acnagy commented Feb 5, 2018

@alicetragedy ah, thanks for the ping! I'm definitely a bit busy right now - if you, @Paarmita want to jump in, please do! If there's anything I can do to help/review/brainstorm, definitely let me know 👍

@Paarmita
Copy link

Paarmita commented Feb 5, 2018

@acnagy Yeah, i can work on it. I want some help on how to start.

@wiseemily88
Copy link
Contributor

@alicetragedy- Hi! I’m a first-time contributor and was hoping to help out with this issue & I noticed in the comments that @Paarmita and @acnagy are working on it. I'd love to help, and wanted to check in on the current status for this issue. Is there currently a solution in progress?

@acnagy
Copy link
Collaborator

acnagy commented Mar 5, 2018

Hey @Paarmita @wiseemily88! Thank you so much for the enthusiasm, so sorry for the delay here. I don't think we have a concrete design, other than iterating on the blog post styling we have (cc: @alicetragedy - lemme know if that's incorrect). With that in mind, here's what I planned, but sadly have not implemented:

  • Start with the whitespace issue - that probably means things link larger line heights, without necessarily increasing font, slightly larger margins and padding - though, I'd definitely experiment
  • Some divs, as @alicetragedy suggested for
    • centering things (images), changing image widths - I'd do 25%, 33%, 50%, 67%, and 75% -
    • potentially also do some div's so images can be inline?
  • Make sub-headers links
  • Make a block quote div (for emphasis)

Do those ideas help get you started? Lemme know if there's anything I can do to help / clarify 🌷

@alicetragedy
Copy link
Member Author

Sorry for the delay in getting back to you, @Paarmita @wiseemily88 — I second what @acnagy said, I think those are good pointers to get started! For now I would stick to the text size and not make any changes, but rather try to experiment with margin and padding sizes. Maybe you'd like to pair together on this or split the work? Please don't hesitate to ping us if you have any questions, and thank you so much for looking into this issue! 🎉

@Paarmita
Copy link

Paarmita commented Mar 7, 2018

@alicetragedy @acnagy I could start with white space issue :)
So do I have to change the RGSoC 2018's Applications section and then further that in the blog post?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants