Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of fields_for method with memoization #2474

Open
wants to merge 3 commits into
base: 0-10-stable
Choose a base branch
from

Conversation

saiqulhaq
Copy link

@saiqulhaq saiqulhaq commented Jun 29, 2024

Description

This PR implements memoization to improve the performance of the fields_for method in the ActiveModel::Serializer::Fieldset class.

I found that this gem calls #fields_for method multiple times.

Motivation and Context

The current implementation of fields_for performs string manipulations and hash lookups on every call. By memoizing the results, we can significantly reduce redundant operations, especially when the method is called frequently with the same type.

How Has This Been Tested?

The existing test suite was run before and after the changes. All tests pass, and there's a noticeable performance improvement:

Without memoization:
Finished in 2.639453s, 217.8482 runs/s, 377.7298 assertions/s.

With memoization:
Finished in 2.465571s, 233.2117 runs/s, 404.3688 assertions/s.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant