Skip to content

Commit 42c71b8

Browse files
authored
Merge pull request #180 from rackerlabs/issue-179
Added logic for SiteSerializer when handling email_scan_alerts and em…
2 parents b3be7c3 + c9d65f9 commit 42c71b8

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

master/django_scantron/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = "1.21"
1+
__version__ = "1.22"

master/django_scantron/api/serializers.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,14 @@ def validate(self, attrs):
6363
invalid_targets = ",".join(targets_dict["invalid_targets"])
6464
raise serializers.ValidationError(f"Invalid excluded targets provided: {invalid_targets}")
6565

66-
# Email scan alerts and email addresses.
67-
email_scan_alerts = attrs["email_scan_alerts"]
68-
email_alert_address = attrs["email_alert_address"]
66+
# Email scan alerts and email address.
67+
if ("email_scan_alerts" in attrs) and ("email_alert_address" in attrs):
6968

70-
if email_scan_alerts and not email_alert_address:
71-
raise serializers.ValidationError(f"Provide an email address if enabling 'Email scan alerts'")
69+
email_scan_alerts = attrs["email_scan_alerts"]
70+
email_alert_address = attrs["email_alert_address"]
71+
72+
if email_scan_alerts and not email_alert_address:
73+
raise serializers.ValidationError(f"Provide an email address if enabling 'Email scan alerts'")
7274

7375
return attrs
7476

0 commit comments

Comments
 (0)