From e9f473bcfac082e8377b5b29bbd4887ccd6b141f Mon Sep 17 00:00:00 2001
From: puni4220 <punitshankar.kundal@rackspace.com>
Date: Fri, 17 Jan 2025 09:07:24 -0500
Subject: [PATCH] remove tests directory from the octavia_preconf role and
 enclose variable names in double quotes in shell scripts

---
 .../octavia_preconf/files/create_health_mgr_ports.sh   | 10 +++++-----
 .../roles/octavia_preconf/files/create_k8s_secret.sh   | 10 +++++-----
 ansible/roles/octavia_preconf/tasks/octavia_cert.yml   |  3 ---
 ansible/roles/octavia_preconf/tests/inventory          |  2 --
 ansible/roles/octavia_preconf/tests/test.yml           |  5 -----
 5 files changed, 10 insertions(+), 20 deletions(-)
 delete mode 100644 ansible/roles/octavia_preconf/tests/inventory
 delete mode 100644 ansible/roles/octavia_preconf/tests/test.yml

diff --git a/ansible/roles/octavia_preconf/files/create_health_mgr_ports.sh b/ansible/roles/octavia_preconf/files/create_health_mgr_ports.sh
index 24d4f926..bf5d47bd 100755
--- a/ansible/roles/octavia_preconf/files/create_health_mgr_ports.sh
+++ b/ansible/roles/octavia_preconf/files/create_health_mgr_ports.sh
@@ -20,15 +20,15 @@ CONTROLLER_IP_PORT_LIST=''
 CTRLS=$(kubectl get nodes -l openstack-control-plane=enabled -o name | awk -F"/" '{print $2}')
 for node in $CTRLS
 do
-  node_short=$(echo $node | awk -F"." '{print $1}')
+  node_short=$(echo "$node" | awk -F"." '{print $1}')
   PORTNAME=octavia-health-manager-port-$node_short
-  PORT_ID=$(openstack port create $PORTNAME --security-group $SECGRP_ID --device-owner Octavia:health-mgr --host=$node -c id -f value --network $NET_ID)
-  IP=$(openstack port show $PORT_ID -c fixed_ips -f yaml | grep ip_address | awk -F':' '{print $2}')
-  if [ -z $CONTROLLER_IP_PORT_LIST ]; then
+  PORT_ID=$(openstack port create "$PORTNAME" --security-group "$SECGRP_ID" --device-owner Octavia:health-mgr --host="$node" -c id -f value --network "$NET_ID")
+  IP=$(openstack port show "$PORT_ID" -c fixed_ips -f yaml | grep ip_address | awk -F':' '{print $2}')
+  if [ -z "$CONTROLLER_IP_PORT_LIST" ]; then
     CONTROLLER_IP_PORT_LIST=$IP:5555
   else
     CONTROLLER_IP_PORT_LIST=$CONTROLLER_IP_PORT_LIST,$IP:5555
   fi
 done
 
-echo $CONTROLLER_IP_PORT_LIST > /tmp/octavia_hm_controller_ip_port_list
+echo "$CONTROLLER_IP_PORT_LIST" > /tmp/octavia_hm_controller_ip_port_list
diff --git a/ansible/roles/octavia_preconf/files/create_k8s_secret.sh b/ansible/roles/octavia_preconf/files/create_k8s_secret.sh
index da1934d6..41e604dd 100755
--- a/ansible/roles/octavia_preconf/files/create_k8s_secret.sh
+++ b/ansible/roles/octavia_preconf/files/create_k8s_secret.sh
@@ -14,7 +14,7 @@ CLIENT_KEY_CERT=$4
 function encod_base64()
 {
   local file_path=$1
-  cat $file_path | base64 -w0 | tr -d '\n'
+  cat "$file_path" | base64 -w0 | tr -d '\n'
 }
 
 cat <<EOF> /tmp/k8s_secret.yml
@@ -26,8 +26,8 @@ metadata:
   namespace: openstack
 type: Opaque
 data:
-  server_ca.cert.pem: $(encod_base64 $SERVER_CA)
-  server_ca.key.pem: $(encod_base64 $SERVER_CA_KEY)
-  client_ca.cert.pem: $(encod_base64 $CLIENT_CA)
-  client.key-and-cert.pem: $(encod_base64 $CLIENT_KEY_CERT)
+  server_ca.cert.pem: $(encod_base64 "$SERVER_CA")
+  server_ca.key.pem: $(encod_base64 "$SERVER_CA_KEY")
+  client_ca.cert.pem: $(encod_base64 "$CLIENT_CA")
+  client.key-and-cert.pem: $(encod_base64 "$CLIENT_KEY_CERT")
 EOF
diff --git a/ansible/roles/octavia_preconf/tasks/octavia_cert.yml b/ansible/roles/octavia_preconf/tasks/octavia_cert.yml
index 8357d697..2230377b 100644
--- a/ansible/roles/octavia_preconf/tasks/octavia_cert.yml
+++ b/ansible/roles/octavia_preconf/tasks/octavia_cert.yml
@@ -119,9 +119,6 @@
     cmd: create_k8s_secret.sh {{ octavia_server_ca_cert }} {{ octavia_serverca_privkey }} {{ octavia_client_ca_cert }} {{ octavia_client_key_cert }}
     creates: /tmp/k8s_secret.yml
 
-#- name: Create the "octavia-certs" secret in the openstack namespace
-#  command:
-#    cmd: kubectl apply -f /tmp/k8s_secret.yml
 - name: Create the "octavia-certs" secret in the openstack namespace
   k8s:
     state: present
diff --git a/ansible/roles/octavia_preconf/tests/inventory b/ansible/roles/octavia_preconf/tests/inventory
deleted file mode 100644
index 878877b0..00000000
--- a/ansible/roles/octavia_preconf/tests/inventory
+++ /dev/null
@@ -1,2 +0,0 @@
-localhost
-
diff --git a/ansible/roles/octavia_preconf/tests/test.yml b/ansible/roles/octavia_preconf/tests/test.yml
deleted file mode 100644
index 7e4e0a86..00000000
--- a/ansible/roles/octavia_preconf/tests/test.yml
+++ /dev/null
@@ -1,5 +0,0 @@
----
-- hosts: localhost
-  remote_user: root
-  roles:
-    - octavia_preconf