Don't rely on deprecated WMIC in `rabbitmq-echopid.bat`

[FinWatling]

rabbitmq-server/deps/rabbit/scripts/rabbitmq-echopid.bat

Line 28 in 4d60fc4

for /f "usebackq tokens=* skip=1" %%P IN (`%%WMIC_PATH%% process where "name='erl.exe' and commandline like '%%%RABBITMQ_NAME_TYPE% %1%%'" get processid 2^>nul`) do (

WMI Command Line utility deprecation

[lukebakken]

It should be extremely easy to replace this with PowerShell. A pull request with an implementation would be welcome. Thanks!

[FinWatling]

The entire rabbitmq-echopid file, or just the WMIC query? I think we'll need to allow Powershell OR WMIC PID lookup as I'm not sure if it's safe to assume that all users will have PowerShell installed.. (pre win 7 installs possible?) Please advise and I'll create a PR :)

[michaelklishin]

@FinWatling we do not support Windows releases older than 2016 in practice (and even that is a bit ridiculous because for Linux distributions, the cut-off is ≈ 5 years, that is, distributions older than 2020 are not even listed as supported).

[lukebakken]

Yes, it's safe to assume all users will have PowerShell at this time. Please do the following:

• Create a new rabbitmq-echopid.ps1 script that does all of the work.
• Replace rabbitmq-echopid.bat's contents with those that will call PowerShell on the "real" script. It should prefer pwsh.exe and only fallback to %SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe if pwsh.exe isn't available.

The "fun" part will be executing rabbitmq-env.bat via PowerShell to get the RABBITMQ_NAME_TYPE environment variable value, or getting that value by some other means.

Or, if you'd like, just replace the wmic.exe bit with PowerShell! Your call!