Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach timestamp to node_events #14

Open
kjnilsson opened this issue Dec 10, 2018 · 0 comments
Open

Attach timestamp to node_events #14

kjnilsson opened this issue Dec 10, 2018 · 0 comments
Milestone

Comments

@kjnilsson
Copy link
Contributor

Currently there is no way for a watcher that receives a node_event to make any judgement on how long ago the state change was observed. Depending on the watcher process implementation it could have spent significant time in the mailbox. If we attach a timestamp to the node_event, receivers of the event can at least evaluate the freshness of the event and possibly choose to ignore it or wait a bit to see if another state change might have been emitted.

A timestamp should be good enough given watchers should only reside on the same erlang node as the aten detector process.

This is a breaking change.

@lukebakken lukebakken added this to the 1.0.0 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants