-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Defacing module (version 2?) #62
base: master
Are you sure you want to change the base?
Conversation
Eric, you can use this branch (after pull and |
a small issue, we need to pay attention to, is to ensure slice percent location 50 is actually "middle" of the brain in each view. I will double check the implementation of |
Hi @Arshitha, to integrate fsleyes, work off the v2_defacing branch that this PR is based on. it's a also a good practice not to use |
okay, thanks @raamana ! I created a new branch but it makes more sense to use v2_defacing branch. :) I'll keep you posted on my progress |
sounds good! keep me posted. |
@raamana As I'm working on defacing scans again, I'm trying to figure out an easier way to generate 3D renders. |
not really! can you try rerun fsleyes script, after setting MPL with below, before running the for loop? matplotlib.use('Agg')
matplotlib.interactive(False) maybe @pauldmccarthy has some ideas on how to keep FSLeyes in the background / batch processing mode? |
Thanks @raamana ! I was able to figure with the help our HPC staff. I missed the key instruction of |
awesome! I can't wait to incorporate fsleyes render into the defacing module, if I can find a way to easily install it on most common OSes. |
@raamana Conda is definitely the easiest method for installing FSLeyes, e.g.:
Using pip is problematic, as wxPython wheels for Linux are not available on pypi (they are hosted separately at https://extras.wxpython.org/wxPython4/extras/linux/gtk3/), and a range of wxPython dependencies need to be installed by the OS package manager. In contrast, installing with conda/mamba will install all of the required dependencies in a single step, and works on macOS and all Linux flavours (and Windows too, assuming that a reasonable OpenGL version is supported). |
thanks Paul - few questions:
|
also, given we don't need any FSLeyes GUI at all, I am wondering if there is a way to do away with even if we a bit of GUI/canvas is needed, we can try replace |
Replacing wxPython with a different toolkit is not really an option, as there is far too much wxPython-specific code in FSLeyes. I did consider TKinter very early on, but it has poor support for OpenGL (at least it did in 2014), so was basically a non-starter. Allowing off-screen rendering without having wxPython installed should be possible, but would require quite a bit of refactoring, so is unlikely to happen any time soon. It's a nice idea though, so I may be able to look into it at some point (unless somebody else wants to have a go - contributions are welcome!). With that said...
For volumetric rendering you need everything in
Conda is the best option from my perspective, as it works on every platform, and takes care of non-python dependencies. Have you tried However, of course it is possible to script a pypi-based installation. There are some notes in the FSLeyes user docs which you may find useful. On macOS you need to:
On Linux you need to:
|
thanks very much Paul for the detailed notes - can you dumb down the macOS installation instructions further (exactly where to get wheels and how to apply them locally etc)? thanks |
incorporating valuable suggestions from @Arshitha @ericearl et al.
fixes #59 #60
and maybe even #61 let's see :)