Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeUsage -> TypeDefinition+TypeUsage #22

Open
KitsuneRal opened this issue Dec 25, 2017 · 0 comments
Open

TypeUsage -> TypeDefinition+TypeUsage #22

KitsuneRal opened this issue Dec 25, 2017 · 0 comments

Comments

@KitsuneRal
Copy link
Member

Translator::mapType() now has to make a copy of TypeUsage (with all its attributes), which is very inefficient given how many times types should be resolved while analysing API specs. The situation can be solved easily for non-parameterised types by pointing to the type instead of copying. For parameterised types it's more complicated since that pointer would need to be accompanied with type parameters. As noted in the comment in Translator::mapType(), TypeUsage should become a "smart handle" to an instance of a newly-made TypeDefinition structure that would own all the stuff TypeUsage now has, except innerTypes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant