Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface contributeur : améliorer le système d'upload d'images #1864

Closed
raphodn opened this issue May 17, 2022 · 2 comments · Fixed by #1887 or #1889 · May be fixed by #1890
Closed

Interface contributeur : améliorer le système d'upload d'images #1864

raphodn opened this issue May 17, 2022 · 2 comments · Fixed by #1887 or #1889 · May be fixed by #1890

Comments

@raphodn
Copy link
Member

raphodn commented May 17, 2022

Quoi ?

Permettre aux contributeurs d'ajouter simplement les images (sur les questions ou les quizs)

Pourquoi ?

Actuellement, l"upload se fait via github (public-frontend/data/images) mais cela pose plusieurs problèmes :

  • l'upload via PR Github n'est pas simple
  • les images des questions & quizs privés sont rendues publiques

Comment ?

Dropzone + Scaleway S3 ?

@raphodn raphodn added the devops label May 17, 2022
@raphodn raphodn changed the title Améliorer le système d'upload d'images Admin : améliorer le système d'upload d'images May 20, 2022
@raphodn raphodn changed the title Admin : améliorer le système d'upload d'images Interface contributeur : améliorer le système d'upload d'images May 29, 2022
@raphodn raphodn linked a pull request Jun 3, 2022 that will close this issue
@raphodn
Copy link
Member Author

raphodn commented Jun 3, 2022

Reste à faire

  • basculer les images hébergées sur Github vers le nouvel hébergeur
  • basculer les autres images vers S3 ?
  • améliorer le système de nommage des images ? quid de l'ID de la question/quiz lorsqu'en mode "création" ?

@raphodn raphodn linked a pull request Jun 5, 2022 that will close this issue
@raphodn
Copy link
Member Author

raphodn commented Jun 6, 2022

Suppression des images du repo https://github.com/quiz-anthropocene/public-frontend

// upload audio
git filter-branch --index-filter 'git rm -r --cached --ignore-unmatch data/audio' --prune-empty -f HEAD
git filter-branch --index-filter 'git rm -r --cached --ignore-unmatch data/images/quizs' --prune-empty -f HEAD
// upload laydgeur & atelier images
git filter-branch --index-filter 'git rm -r --cached --ignore-unmatch data/images' --prune-empty -f HEAD

@raphodn raphodn linked a pull request Jun 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant