Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@inline-statements in src/structs.jl seem to bloat the precompiled size and slow TTFX #279

Closed
jaakkor2 opened this issue May 6, 2024 · 0 comments · Fixed by #282
Closed

Comments

@jaakkor2
Copy link
Contributor

jaakkor2 commented May 6, 2024

Ref: JuliaLang/julia#53570 (comment)
Precompiled GLTF size on Julia v1.11.0-beta1 is a whopping 211 MB.
Removing @inline statements from src/structs.jl the precompiled size drops to 13 MB

On Julia v1.10.3, precompiled size is 43 MB

using GLTF
@time load(joinpath(pkgdir(GLTF), "assets", "DamagedHelmet.gltf"));

gives

5.356109 seconds (3.35 M allocations: 166.812 MiB, 0.80% gc time, 99.99% compilation time)

and without @inline in src/structs.jl the precompiled size is 10 MB and

 0.384157 seconds (677.40 k allocations: 49.200 MiB, 8.62% gc time, 99.85% compilation time)

On 1.11.0-beta1, TTFX seems to be fast in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant