Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit search requests concurrency #5559

Open
guilload opened this issue Nov 21, 2024 · 1 comment
Open

Limit search requests concurrency #5559

guilload opened this issue Nov 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@guilload
Copy link
Member

Reject search requests with TooManyRequests when too many requests are in flight. This should be done at the root search level.

Screenshot 2024-11-21 at 3 42 30 PM
@guilload guilload added the bug Something isn't working label Nov 21, 2024
@fulmicoton
Copy link
Contributor

I think we tend to use the following terminology:

  • concurrency limiting: process only n request at a time, and have the others wait in queue.
  • load shedding: returning an error right away if two many clients are waiting.

and we usually use them in combination.

Here I think @guilload wants load shedding. (we already have concurrency limiting, at least at the leaf search split level)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants