Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't require multiple addresses for CM testcases #420

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

larseggert
Copy link
Contributor

Inherit from TestCasePortRebinding rather than TestCaseAddressRebinding.

Fixes #419

Inherit from `TestCasePortRebinding` rather than `TestCaseAddressRebinding`.

Fixes quic-interop#419
@larseggert
Copy link
Contributor Author

@marten-seemann this is kinda essential for the test to actually make sense.

@marten-seemann
Copy link
Collaborator

I don't understand this fix. What's the problem, and how is this PR fixing it?

@larseggert
Copy link
Contributor Author

The problem was that inheriting from TestCaseAddressRebinding requires seeing multiple client addresses for a pass, which is incorrect (too strict). It just needs to be multiple paths (i.e., multiple pairs of IP addresses and ports).

@marten-seemann
Copy link
Collaborator

How is "path" defined here? Isn't it the 4-tuple? How is it possible to have multiple client addresses on the same path?

@larseggert
Copy link
Contributor Author

TestCaseAddressRebinding requires the runner to see the client use at least two distinct IP addresses to pass the test. When CM inherits from it, that extends to the CM test, which is too strict. It is enough that two paths are used by the client, i.e., two different IP address/port pairs.

@marten-seemann
Copy link
Collaborator

Thank you for the explanation!

@marten-seemann marten-seemann merged commit aa1bd7b into quic-interop:master Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CM bug when migrating within one address family
2 participants