Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension cannot be installed with @quasar/[email protected] #17797

Open
Grkmus opened this issue Jan 28, 2025 · 1 comment
Open

Extension cannot be installed with @quasar/[email protected] #17797

Grkmus opened this issue Jan 28, 2025 · 1 comment
Labels
area/app-ext bug/1-hard-to-reproduce A reproduction is available, but it's hard to reproduce, so it has a lower priority. bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@Grkmus
Copy link

Grkmus commented Jan 28, 2025

What happened?

I am not able to invoke my extension in a quasar project. I got this error

App • Updating /quasar.extensions.json for "@vanoord/datalab" extension ...
/<directory>/node_modules/@quasar/app-webpack/lib/app-extension/create-app-ext.js:29
      stringifyJSON(json, { indent: fileExists ? undefined : 2 }),
                                    ^

ReferenceError: fileExists is not defined
    at save (/<directory>/node_modules/@quasar/app-webpack/lib/app-extension/create-app-ext.js:29:37)
    at Object.set (/<directory>/node_modules/@quasar/app-webpack/lib/app-extension/create-app-ext.js:43:7)
    at AppExtensionInstance.install (/<directory>/node_modules/@quasar/app-webpack/lib/app-extension/AppExtensionInstance.js:235:22)
    at async runExtAction (/<directory>/node_modules/@quasar/app-webpack/lib/cmd/ext.js:69:3)

Node.js v20.15.1

When I go to the @quasar/app-webpack/lib/app-extension/create-app-ext.js:29:37 file I can see that the fileExists is actually not defined. Maybe it is a mistake?

What did you expect to happen?

I was expecting to install my extension successfully, I am able to install with v4.0.7

Reproduction URL

stringifyJSON(json, { indent: fileExists ? undefined : 2 }),

How to reproduce?

  1. Go to the link,
  2. And see fileExists is actually not defined

Flavour

Quasar CLI with Webpack (@quasar/cli | @quasar/app-webpack)

Areas

App Extension API

Platforms/Browsers

Chrome

Quasar info output

Relevant log output

Additional context

No response

@Grkmus Grkmus added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Jan 28, 2025
@github-actions github-actions bot added area/app-ext bug/1-hard-to-reproduce A reproduction is available, but it's hard to reproduce, so it has a lower priority. bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack labels Jan 28, 2025
@yusufkandemir
Copy link
Member

This was already fixed in bd70884, but not released yet. The fix will be included in the next app-webpack release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-ext bug/1-hard-to-reproduce A reproduction is available, but it's hard to reproduce, so it has a lower priority. bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

2 participants