Create Stock and Order classes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated PR to include new commit (added |
fnorman
requested changes
Oct 17, 2023
| int currentPrice, | ||
| int shares, | ||
| int marketCap, | ||
| std::map<std::string, int> priceLog |
Comment on lines
+11
to
+13
| int currentPrice, | ||
| int shares, | ||
| int marketCap, |
There was a problem hiding this comment.
Since these things are dynamic with time, I'm hesitant to include them inside of this class; however, we can leave them in for now given they provide some value.
| int orderId; | ||
| int userId; | ||
| std::string ticker; | ||
| bool isBuy; |
There was a problem hiding this comment.
Instead of using a bool, let's use an enum. This is so that we can include more information than just buy or sell such as LimitBuy, LimitSell, etc...
There was a problem hiding this comment.
To specify, this is to replace the bool isBuy
Comment on lines
+19
to
+20
| std::string ticker, | ||
| std::string companyName, |
There was a problem hiding this comment.
Can pass a Stock object here to avoid duplicate work, same as below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1 and Issue #2 by creating
StockandOrderclasses.