Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional deps #50

Open
stefanpenner opened this issue Oct 30, 2015 · 1 comment
Open

optional deps #50

stefanpenner opened this issue Oct 30, 2015 · 1 comment

Comments

@stefanpenner
Copy link
Collaborator

people may be having issues with optional deps not being installed, but validated...

ember-cli/ember-cli#4965
@tamzinblake tamzinblake mentioned this issue Apr 21, 2017
Open
@SergeAstapov
Copy link
Contributor

SergeAstapov commented Sep 22, 2017 •
edited
Loading

We faced that issue with fsevents not being installed when developers create npm-shrinkwrap.json on their laptop with Mac OS and CI runs Linux.
fsevents supports Mac OS only and marked as "optional": true. As a result builds on CI are failing due to error reported by ember-cli-dependency-checker.

@stefanpenner what's your thought about using warn for optional dependencies instead of throwing an error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanpenner @SergeAstapov