Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: When doing CMD+F to search, second use of it doesn’t highlight existing search #2125

Open
cole-at-quadratic opened this issue Dec 12, 2024 · 4 comments · May be fixed by #2108
Open

BUG: When doing CMD+F to search, second use of it doesn’t highlight existing search #2125

cole-at-quadratic opened this issue Dec 12, 2024 · 4 comments · May be fixed by #2108
Assignees
@davidfig
Labels
type: bug something is broken

Comments

@cole-at-quadratic
Copy link

https://www.loom.com/share/45ca3d7452514f4ca63d600278ff7e5f?sid=5a773df2-f361-4e6a-909d-61a34dc2002d

Annoying to do another search and have to manually delete the previous query
@cole-at-quadratic cole-at-quadratic added the type: bug something is broken label Dec 12, 2024
@davidfig davidfig linked a pull request Dec 17, 2024 that will close this issue
QA Nov 27 #2108
Open
@davidfig
Copy link
Collaborator

I added a fix in QA. Please test.

@davidfig davidfig self-assigned this Dec 17, 2024
@cole-at-quadratic
Copy link
Author

@davidfig it works when you click away from the input box into a cell, then do CMD+F again. But it doesn't work when you CMD+F search something, then CMD+F again without moving the cursor out of the input box

@davidfig
Copy link
Collaborator

Pushed that feature.

@cole-at-quadratic
Copy link
Author

@davidfig it works. Great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidfig davidfig

Labels
type: bug something is broken
Projects
Quadratic Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

QA Nov 27 quadratichq/quadratic
2 participants
@davidfig @cole-at-quadratic